fix: handle undefined tax service banner counter in state (#6178)

* fix

* use ternary

* update

src/components/TaxServiceModal/TaxServiceBanner.tsx

@@ -122,7 +122,7 @@ export default function TaxServiceBanner() {
     sessionStorage.setItem(TAX_SERVICE_DISMISSED, 'false')
   }
   const [bannerOpen, setBannerOpen] = useState(
-    sessionStorageTaxServiceDismissed !== 'true' && dismissals < MAX_RENDER_COUNT
+    sessionStorageTaxServiceDismissed !== 'true' && (dismissals === undefined || dismissals < MAX_RENDER_COUNT)
   )
   const onDismiss = useCallback(() => {
     setModalOpen(false)
@@ -131,7 +131,7 @@ export default function TaxServiceBanner() {
   const handleClose = useCallback(() => {
     sessionStorage.setItem(TAX_SERVICE_DISMISSED, 'true')
     setBannerOpen(false)
-    addTaxServiceDismissal(dismissals + 1)
+    dismissals === undefined ? addTaxServiceDismissal(1) : addTaxServiceDismissal(dismissals + 1)
   }, [addTaxServiceDismissal, dismissals])
 
   const handleLearnMoreClick = useCallback((e: any) => {

src/state/user/hooks.tsx

@@ -93,7 +93,7 @@ export function useIsExpertMode(): boolean {
   return useAppSelector((state) => state.user.userExpertMode)
 }
 
-export function useTaxServiceDismissal(): [number, (dismissals: number) => void] {
+export function useTaxServiceDismissal(): [number | undefined, (dismissals: number) => void] {
   const dispatch = useAppDispatch()
   const taxServiceDismissals = useAppSelector((state) => state.user.taxServiceDismissals)
   const setDismissals = useCallback(

src/state/user/reducer.ts

@@ -9,7 +9,7 @@ import { SerializedPair, SerializedToken } from './types'
 const currentTimestamp = () => new Date().getTime()
 
 export interface UserState {
-  taxServiceDismissals: number
+  taxServiceDismissals: number | undefined
 
   selectedWallet?: ConnectionType