Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
I
interface
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
LuckySwap
interface
Commits
f71c7815
Unverified
Commit
f71c7815
authored
Sep 11, 2023
by
eddie
Committed by
GitHub
Sep 11, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix: add tax amounts to swap quote received (#7299)
parent
736e395c
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
3 deletions
+7
-3
analytics.ts
src/lib/utils/analytics.ts
+5
-1
index.tsx
src/pages/Swap/index.tsx
+2
-2
No files found.
src/lib/utils/analytics.ts
View file @
f71c7815
...
@@ -86,7 +86,9 @@ function getQuoteMethod(trade: InterfaceTrade) {
...
@@ -86,7 +86,9 @@ function getQuoteMethod(trade: InterfaceTrade) {
export
const
formatSwapQuoteReceivedEventProperties
=
(
export
const
formatSwapQuoteReceivedEventProperties
=
(
trade
:
InterfaceTrade
,
trade
:
InterfaceTrade
,
allowedSlippage
:
Percent
,
allowedSlippage
:
Percent
,
swapQuoteLatencyMs
:
number
|
undefined
swapQuoteLatencyMs
:
number
|
undefined
,
inputTax
:
Percent
,
outputTax
:
Percent
)
=>
{
)
=>
{
return
{
return
{
...
formatCommonPropertiesForTrade
(
trade
,
allowedSlippage
),
...
formatCommonPropertiesForTrade
(
trade
,
allowedSlippage
),
...
@@ -95,5 +97,7 @@ export const formatSwapQuoteReceivedEventProperties = (
...
@@ -95,5 +97,7 @@ export const formatSwapQuoteReceivedEventProperties = (
token_in_amount_max
:
trade
.
maximumAmountIn
(
allowedSlippage
).
toExact
(),
token_in_amount_max
:
trade
.
maximumAmountIn
(
allowedSlippage
).
toExact
(),
token_out_amount_min
:
trade
.
minimumAmountOut
(
allowedSlippage
).
toExact
(),
token_out_amount_min
:
trade
.
minimumAmountOut
(
allowedSlippage
).
toExact
(),
quote_latency_milliseconds
:
swapQuoteLatencyMs
,
quote_latency_milliseconds
:
swapQuoteLatencyMs
,
token_out_detected_tax
:
formatPercentNumber
(
outputTax
),
token_in_detected_tax
:
formatPercentNumber
(
inputTax
),
}
}
}
}
src/pages/Swap/index.tsx
View file @
f71c7815
...
@@ -552,10 +552,10 @@ export function Swap({
...
@@ -552,10 +552,10 @@ export function Swap({
if
(
!
trade
||
prevTrade
===
trade
)
return
// no new swap quote to log
if
(
!
trade
||
prevTrade
===
trade
)
return
// no new swap quote to log
sendAnalyticsEvent
(
SwapEventName
.
SWAP_QUOTE_RECEIVED
,
{
sendAnalyticsEvent
(
SwapEventName
.
SWAP_QUOTE_RECEIVED
,
{
...
formatSwapQuoteReceivedEventProperties
(
trade
,
allowedSlippage
,
swapQuoteLatency
),
...
formatSwapQuoteReceivedEventProperties
(
trade
,
allowedSlippage
,
swapQuoteLatency
,
inputTax
,
outputTax
),
...
trace
,
...
trace
,
})
})
},
[
prevTrade
,
trade
,
trace
,
allowedSlippage
,
swapQuoteLatency
])
},
[
prevTrade
,
trade
,
trace
,
allowedSlippage
,
swapQuoteLatency
,
inputTax
,
outputTax
])
const
showDetailsDropdown
=
Boolean
(
const
showDetailsDropdown
=
Boolean
(
!
showWrap
&&
userHasSpecifiedInputOutput
&&
(
trade
||
routeIsLoading
||
routeIsSyncing
)
!
showWrap
&&
userHasSpecifiedInputOutput
&&
(
trade
||
routeIsLoading
||
routeIsSyncing
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment