remove unused retry timeout constants

src/participant_network/cl/lighthouse/lighthouse_launcher.star

@@ -29,10 +29,6 @@ BEACON_DISCOVERY_PORT_NUM = 9000
 BEACON_HTTP_PORT_NUM      = 4000
 BEACON_METRICS_PORT_NUM   = 5054
 
-# TODO remove if facts & waits doesn't need this
-MAX_NUM_HEALTHCHECK_RETRIES      = 10
-TIME_BETWEEN_HEALTHCHECK_RETRIES = 1 * time.second
-
 #  ---------------------------------- Validator client -------------------------------------
 VALIDATING_REWARDS_ACCOUNT = "0x0000000000000000000000000000000000000000"
 

src/participant_network/cl/lodestar/lodestar_launcher.star

@@ -23,10 +23,6 @@ HTTP_PORT_NUM                    = 4000
 METRICS_PORT_NUM           = 8008
 VALIDATOR_METRICS_PORT_NUM        = 5064
 
-# TODO Remove this if facts & waits doesn't need this
-MAX_NUM_HEALTHCHECK_RETRIES      = 30
-TIME_BETWEEN_HEALTHCHECK_RETRIES = 2 * time.second
-
 BEACON_SUFFIX_SERVICE_ID    = "beacon"
 VALIDATOR_SUFFIX_SERVICE_ID = "validator"
 

src/participant_network/cl/nimbus/nimbus_launcher.star

@@ -36,10 +36,6 @@ DEFAULT_IMAGE_ENTRYPOINT = "/home/user/nimbus-eth2/build/nimbus_beacon_node"
 VALIDATOR_KEYS_DIRPATH_ON_SERVICE_CONTAINER    = "$HOME/validator-keys"
 VALIDATOR_SECRETS_DIRPATH_ON_SERVICE_CONTAINER = "$HOME/validator-secrets"
 
-# TODO remove this if time and wait cant use this
-MAX_NUM_HEALTHCHECK_RETRIES      = 60
-TIME_BETWEEN_HEALTHCHECK_RETRIES = 1 * time.second
-
 METRICS_PATH = "/metrics"
 
 PRIVATE_IP_ADDRESS_PLACEHOLDER = "KURTOSIS_IP_ADDR_PLACEHOLDER"
@@ -199,7 +195,7 @@ def get_service_config(
 		cmd_args.append("--bootstrap-node="+boot_cl_client_ctx.enr)
 
 	if mev_boost_context != None:
-		# TODO add `mev-boost` support once the feature lands on `stable` - from eth2-merge-kurtosis-module
+		# TODO(old) add `mev-boost` support once the feature lands on `stable` - from eth2-merge-kurtosis-module
 		pass
 
 

src/participant_network/cl/prysm/prysm_launcher.star

@@ -30,9 +30,6 @@ HTTP_PORT_NUM                 = 3500
 BEACON_MONITORING_PORT_NUM     = 8080
 VALIDATOR_MONITORING_PORT_NUM  = 8081
 
-MAX_NUM_HEALTHCHECK_RETRIES      = 100
-TIME_BETWEEN_HEALTHCHECK_RETRIES = 5 * time.second
-
 BEACON_SUFFIX_SERVICE_ID    = "beacon"
 VALIDATOR_SUFFIX_SERVICE_ID = "validator"
 

src/participant_network/cl/teku/teku_launcher.star

@@ -41,10 +41,6 @@ METRICS_PORT_NUM = 8008
 DEST_VALIDATOR_KEYS_DIRPATH_IN_SERVICE_CONTAINER    = "$HOME/validator-keys"
 DEST_VALIDATOR_SECRETS_DIRPATH_IN_SERVICE_CONTAINER = "$HOME/validator-secrets"
 
-	# Teku nodes take ~35s to bring their HTTP server up
-MAX_NUM_HEALTHCHECK_RETRIES      = 100
-TIME_BETWEEN_HEALTHCHECK_RETRIES = 2 * time.second
-
 MIN_PEERS = 1
 
 METRICS_PATH = "/metrics"

src/participant_network/el/besu/besu_launcher.star

@@ -23,11 +23,6 @@ UDP_DISCOVERY_PORT_ID = "udp-discovery"
 ENGINE_HTTP_RPC_PORT_ID = "engineHttpRpc"
 ENGINE_WS_RPC_PORT_ID = "engineWsRpc"
 
-# required for wait & fact maybe
-# TODO see if it is otherwise remove
-GET_NODE_INFO_MAX_RETRIES = 20
-GET_NODE_INFO_TIME_BETWEEN_RETRIES = 1 * time.second
-
 PRIVATE_IP_ADDRESS_PLACEHOLDER = "KURTOSIS_IP_ADDR_PLACEHOLDER"
 
 # TODO push this into shared_utils

src/participant_network/el/erigon/erigon_launcher.star

@@ -22,12 +22,6 @@ UDP_DISCOVERY_PORT_ID = "udp-discovery"
 ENGINE_RPC_PORT_ID = "engine-rpc"
 
 
-# required for wait & fact maybe
-# TODO see if it is otherwise remove
-EXPECTED_SECONDS_FOR_ERIGON_INIT = 10
-EXPECTED_SECONDS_AFTER_NODE_START_UNTIL_HTTP_SERVER_IS_AVAILABLE = 20
-GET_NODE_INFO_TIME_BETWEEN_RETRIES = 1 * time.second
-
 PRIVATE_IP_ADDRESS_PLACEHOLDER = "KURTOSIS_IP_ADDR_PLACEHOLDER"
 
 # TODO push this into shared_utils

src/participant_network/el/geth/geth_launcher.star

@@ -29,12 +29,6 @@ PREFUNDED_KEYS_MOUNT_DIRPATH = "/prefunded-keys"
 EXECUTION_DATA_DIRPATH_ON_CLIENT_CONTAINER = "/execution-data"
 KEYSTORE_DIRPATH_ON_CLIENT_CONTAINER      = EXECUTION_DATA_DIRPATH_ON_CLIENT_CONTAINER + "/keystore"
 
-# TODO remove this if facts & waits doesn't need it
-EXPECTED_SECONDS_FOR_GETH_INIT                              = 10
-EXPECTED_SECONDS_PER_KEY_IMPORT                             = 8
-EXPECTED_SECONDS_AFTER_NODE_START_UNTIL_HTTP_SERVER_IS_AVAILABLE = 20
-GET_NODE_INFO_TIME_BETWEEN_RETRIES                           = 1 * time.second
-
 GETH_ACCOUNT_PASSWORD      = "password"          #  Password that the Geth accounts will be locked with
 GETH_ACCOUNT_PASSWORDS_FILE = "/tmp/password.txt" #  Importing an account to
 

src/participant_network/el/nethermind/nethermind_launcher.star

@@ -21,11 +21,6 @@ TCP_DISCOVERY_PORT_ID = "tcp-discovery"
 UDP_DISCOVERY_PORT_ID = "udp-discovery"
 ENGINE_RPC_PORT_ID = "engine-rpc"
 
-# required for wait & fact maybe
-# TODO see if it is otherwise remove
-GET_NODE_INFO_MAX_RETRIES = 30
-GET_NODE_INFO_TIME_BETWEEN_RETRIES = 1 * time.second
-
 PRIVATE_IP_ADDRESS_PLACEHOLDER = "KURTOSIS_IP_ADDR_PLACEHOLDER"
 
 # TODO push this into shared_utils