Skip to content

E
ethereum-package
Commit 53602f1b authored by Ekaterina Riazantseva's avatar Ekaterina Riazantseva Committed by GitHub
1 Browse files
Options

fix: add milliseconds to histograms (#879) 

This PR updates the PeerDAS dashboard histograms to display metrics in
both milliseconds and seconds.

Relates to [PeerDAS metrics
specs](https://github.com/ethereum/beacon-metrics/pull/14)

---------
Co-authored-by: default avatarBarnabas Busa <busa.barnabas@gmail.com>
parent 040e622c
Hide whitespace changes
Inline Side-by-side
Showing with 44 additions and 74 deletions
static_files/grafana-config/dashboards/peerdas-dashboard.json
View file @ 53602f1b
......@@ -19,7 +19,7 @@
"editable": true,
"fiscalYearStartMonth": 0,
"graphTooltip": 0,
"id": 7,
"id": 6,
"links": [],
"panels": [
{
......@@ -118,7 +118,7 @@
"sort": "desc"
}
},
"pluginVersion": "9.1.2",
"pluginVersion": "11.4.0",
"targets": [
{
"datasource": {
......@@ -222,7 +222,7 @@
"sort": "desc"
}
},
"pluginVersion": "9.1.2",
"pluginVersion": "11.4.0",
"targets": [
{
"datasource": {
......@@ -325,7 +325,7 @@
"sort": "desc"
}
},
"pluginVersion": "9.1.2",
"pluginVersion": "11.4.0",
"targets": [
{
"datasource": {
......@@ -402,8 +402,7 @@
"value": 80
}
]
},
"unit": "s"
}
},
"overrides": []
},
......@@ -426,6 +425,7 @@
"sort": "none"
}
},
"pluginVersion": "11.4.0",
"targets": [
{
"datasource": {
......@@ -433,7 +433,7 @@
"uid": "PBFA97CFB590B2093"
},
"editorMode": "code",
"expr": "histogram_quantile(0.99, rate(beacon_data_column_sidecar_gossip_verification_seconds_bucket{client_name=~\"$client\", job=~\"$job\", supernode=~\"$nodes\"}[$__rate_interval]))",
"expr": "(\n histogram_quantile(0.99, rate(beacon_data_column_sidecar_gossip_verification_seconds_bucket {client_name=~\"$client\", job=~\"$job\", supernode=~\"$nodes\"}[$__rate_interval]))\n)\nOR\n(\n histogram_quantile(0.99, rate(beacon_data_column_sidecar_gossip_verification_milliseconds_bucket{\n client_name=~\"$client\",\n job=~\"$job\",\n supernode=~\"$nodes\"\n }[$__rate_interval])) / 1000\n)",
"instant": false,
"legendFormat": "{{job}}",
"range": true,
......@@ -525,7 +525,7 @@
"sort": "desc"
}
},
"pluginVersion": "9.1.2",
"pluginVersion": "11.4.0",
"targets": [
{
"datasource": {
......@@ -602,8 +602,7 @@
"value": 80
}
]
},
"unit": "s"
}
},
"overrides": []
},
......@@ -626,6 +625,7 @@
"sort": "desc"
}
},
"pluginVersion": "11.4.0",
"targets": [
{
"datasource": {
......@@ -633,7 +633,7 @@
"uid": "PBFA97CFB590B2093"
},
"editorMode": "code",
"expr": "histogram_quantile(0.99, rate(beacon_data_availability_reconstruction_time_seconds_bucket{client_name=~\"$client\", job=~\"$job\", supernode=~\"$nodes\"}[$__rate_interval]))",
"expr": "(\n histogram_quantile(0.99, rate(beacon_data_availability_reconstruction_time_seconds_bucket{client_name=~\"$client\", job=~\"$job\", supernode=~\"$nodes\"}[$__rate_interval]))\n)\nOR\n(\n histogram_quantile(0.99, rate(beacon_data_availability_reconstruction_time_milliseconds_bucket{\n client_name=~\"$client\",\n job=~\"$job\",\n supernode=~\"$nodes\"\n }[$__rate_interval])) / 1000\n)",
"legendFormat": "{{job}}",
"range": true,
"refId": "A"
......@@ -700,8 +700,7 @@
"value": 80
}
]
},
"unit": "s"
}
},
"overrides": []
},
......@@ -724,6 +723,7 @@
"sort": "desc"
}
},
"pluginVersion": "11.4.0",
"targets": [
{
"datasource": {
......@@ -731,7 +731,7 @@
"uid": "PBFA97CFB590B2093"
},
"editorMode": "code",
"expr": "histogram_quantile(0.99, rate(data_column_sidecar_computation_seconds_bucket{client_name=~\"$client\", job=~\"$job\", supernode=~\"$nodes\"}[$__rate_interval]))",
"expr": "(\n histogram_quantile(0.99, rate(beacon_data_column_sidecar_computation_seconds_bucket{client_name=~\"$client\", job=~\"$job\", supernode=~\"$nodes\"}[$__rate_interval]))\n)\nOR\n(\n histogram_quantile(0.99, rate(beacon_data_column_sidecar_computation_milliseconds_bucket{\n client_name=~\"$client\",\n job=~\"$job\",\n supernode=~\"$nodes\"\n }[$__rate_interval])) / 1000\n)",
"legendFormat": "{{job}}",
"range": true,
"refId": "A"
......@@ -797,8 +797,7 @@
"value": 80
}
]
},
"unit": "s"
}
},
"overrides": []
},
......@@ -821,6 +820,7 @@
"sort": "desc"
}
},
"pluginVersion": "11.4.0",
"targets": [
{
"datasource": {
......@@ -828,7 +828,7 @@
"uid": "PBFA97CFB590B2093"
},
"editorMode": "code",
"expr": "histogram_quantile(0.99, rate(beacon_data_column_sidecar_inclusion_proof_verification_seconds_bucket{client_name=~\"$client\", job=~\"$job\", supernode=~\"$nodes\"}[$__rate_interval]))",
"expr": "(\n histogram_quantile(0.99, rate(beacon_data_column_sidecar_inclusion_proof_verification_seconds_bucket{client_name=~\"$client\", job=~\"$job\", supernode=~\"$nodes\"}[$__rate_interval]))\n)\nOR\n(\n histogram_quantile(0.99, rate(beacon_data_column_sidecar_inclusion_proof_verification_milliseconds_bucket{\n client_name=~\"$client\",\n job=~\"$job\",\n supernode=~\"$nodes\"\n }[$__rate_interval])) / 1000\n)",
"legendFormat": "{{job}}",
"range": true,
"refId": "A"
......@@ -894,8 +894,7 @@
"value": 80
}
]
},
"unit": "s"
}
},
"overrides": []
},
......@@ -918,6 +917,7 @@
"sort": "desc"
}
},
"pluginVersion": "11.4.0",
"targets": [
{
"datasource": {
......@@ -925,7 +925,7 @@
"uid": "PBFA97CFB590B2093"
},
"editorMode": "code",
"expr": "histogram_quantile(0.99, rate(beacon_kzg_verification_data_column_single_seconds_bucket{client_name=~\"$client\", job=~\"$job\", supernode=~\"$nodes\"}[$__rate_interval]))",
"expr": "(\n histogram_quantile(0.99, rate(beacon_kzg_verification_data_column_single_seconds_bucket{client_name=~\"$client\", job=~\"$job\", supernode=~\"$nodes\"}[$__rate_interval]))\n)\nOR\n(\n histogram_quantile(0.99, rate(beacon_kzg_verification_data_column_single_milliseconds_bucket{\n client_name=~\"$client\",\n job=~\"$job\",\n supernode=~\"$nodes\"\n }[$__rate_interval])) / 1000\n)",
"hide": false,
"legendFormat": "{{job}}",
"range": true,
......@@ -992,8 +992,7 @@
"value": 80
}
]
},
"unit": "s"
}
},
"overrides": []
},
......@@ -1016,6 +1015,7 @@
"sort": "desc"
}
},
"pluginVersion": "11.4.0",
"targets": [
{
"datasource": {
......@@ -1023,7 +1023,7 @@
"uid": "PBFA97CFB590B2093"
},
"editorMode": "code",
"expr": "histogram_quantile(0.99, rate(beacon_kzg_verification_data_column_batch_seconds_bucket{client_name=~\"$client\", job=~\"$job\", supernode=~\"$nodes\"}[$__rate_interval]))",
"expr": "(\n histogram_quantile(0.99, rate(beacon_kzg_verification_data_column_batch_seconds_bucket{client_name=~\"$client\", job=~\"$job\", supernode=~\"$nodes\"}[$__rate_interval]))\n)\nOR\n(\n histogram_quantile(0.99, rate(beacon_kzg_verification_data_column_batch_milliseconds_bucket{\n client_name=~\"$client\",\n job=~\"$job\",\n supernode=~\"$nodes\"\n }[$__rate_interval])) / 1000\n)",
"legendFormat": "{{job}}",
"range": true,
"refId": "A"
......@@ -1112,6 +1112,7 @@
"sort": "desc"
}
},
"pluginVersion": "11.4.0",
"targets": [
{
"datasource": {
......@@ -1221,6 +1222,7 @@
"sort": "none"
}
},
"pluginVersion": "11.4.0",
"targets": [
{
"datasource": {
......@@ -1319,6 +1321,7 @@
"sort": "none"
}
},
"pluginVersion": "11.4.0",
"targets": [
{
"datasource": {
......@@ -1417,6 +1420,7 @@
"sort": "none"
}
},
"pluginVersion": "11.4.0",
"targets": [
{
"datasource": {
......@@ -1482,8 +1486,7 @@
"mode": "absolute",
"steps": [
{
"color": "green",
"value": null
"color": "green"
},
{
"color": "red",
......@@ -1581,8 +1584,7 @@
"mode": "absolute",
"steps": [
{
"color": "green",
"value": null
"color": "green"
},
{
"color": "red",
......@@ -1680,8 +1682,7 @@
"mode": "absolute",
"steps": [
{
"color": "green",
"value": null
"color": "green"
},
{
"color": "red",
......@@ -1793,8 +1794,7 @@
"mode": "absolute",
"steps": [
{
"color": "green",
"value": null
"color": "green"
},
{
"color": "red",
......@@ -1896,8 +1896,7 @@
"mode": "absolute",
"steps": [
{
"color": "green",
"value": null
"color": "green"
},
{
"color": "red",
......@@ -1999,8 +1998,7 @@
"mode": "absolute",
"steps": [
{
"color": "green",
"value": null
"color": "green"
},
{
"color": "red",
......@@ -2102,8 +2100,7 @@
"mode": "absolute",
"steps": [
{
"color": "green",
"value": null
"color": "green"
},
{
"color": "red",
......@@ -2205,8 +2202,7 @@
"mode": "absolute",
"steps": [
{
"color": "green",
"value": null
"color": "green"
},
{
"color": "red",
......@@ -2309,8 +2305,7 @@
"mode": "absolute",
"steps": [
{
"color": "green",
"value": null
"color": "green"
},
{
"color": "red",
......@@ -2413,8 +2408,7 @@
"mode": "absolute",
"steps": [
{
"color": "green",
"value": null
"color": "green"
},
{
"color": "red",
......@@ -2517,8 +2511,7 @@
"mode": "absolute",
"steps": [
{
"color": "green",
"value": null
"color": "green"
},
{
"color": "red",
......@@ -2572,33 +2565,27 @@
"type": "timeseries"
}
],
"preload": false,
"refresh": "15m",
"schemaVersion": 39,
"schemaVersion": 40,
"tags": [],
"templating": {
"list": [
{
"current": {
"selected": true,
"text": [
"All"
"$__all"
],
"value": [
"$__all"
]
},
"description": "",
"hide": 0,
"includeAll": true,
"label": "Client",
"multi": true,
"name": "client",
"options": [
{
"selected": true,
"text": "All",
"value": "$__all"
},
{
"selected": false,
"text": "lighthouse",
......@@ -2631,16 +2618,11 @@
}
],
"query": "lighthouse, teku, prysm, lodestar, grandine, nimbus",
"queryValue": "",
"skipUrlSync": false,
"type": "custom"
},
{
"current": {
"selected": true,
"text": [
"All"
],
"text": "All",
"value": [
"$__all"
]
......@@ -2650,7 +2632,6 @@
"uid": "PBFA97CFB590B2093"
},
"definition": "label_values(job)",
"hide": 0,
"includeAll": true,
"label": "Job",
"multi": true,
......@@ -2663,31 +2644,22 @@
},
"refresh": 1,
"regex": "^cl.*",
"skipUrlSync": false,
"sort": 0,
"type": "query"
},
{
"current": {
"selected": true,
"text": [
"All"
"$__all"
],
"value": [
"$__all"
]
},
"hide": 0,
"includeAll": true,
"label": "Nodes",
"multi": true,
"name": "nodes",
"options": [
{
"selected": true,
"text": "All",
"value": "$__all"
},
{
"selected": false,
"text": "supernodes",
......@@ -2700,8 +2672,6 @@
}
],
"query": "supernodes : True, full nodes : False",
"queryValue": "",
"skipUrlSync": false,
"type": "custom"
}
]
......@@ -2714,6 +2684,6 @@
"timezone": "browser",
"title": "PeerDAS metrics",
"uid": "ddr7j9b1mlszkm",
"version": 15,
"version": 7,
"weekStart": ""
}
\ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment