Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
F
frontend
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
vicotor
frontend
Commits
12d7b900
Commit
12d7b900
authored
Apr 23, 2025
by
tom
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
transactions_count for Scroll batch could be null
parent
5d262cea
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
39 additions
and
29 deletions
+39
-29
scrollL2.ts
types/api/scrollL2.ts
+1
-1
ScrollL2TxnBatchDetails.tsx
ui/txnBatches/scrollL2/ScrollL2TxnBatchDetails.tsx
+15
-11
ScrollL2TxnBatchesListItem.tsx
ui/txnBatches/scrollL2/ScrollL2TxnBatchesListItem.tsx
+15
-11
ScrollL2TxnBatchesTableItem.tsx
ui/txnBatches/scrollL2/ScrollL2TxnBatchesTableItem.tsx
+8
-6
No files found.
types/api/scrollL2.ts
View file @
12d7b900
...
@@ -27,7 +27,7 @@ export type ScrollL2TxnBatch = {
...
@@ -27,7 +27,7 @@ export type ScrollL2TxnBatch = {
confirmation_transaction
:
ScrollL2TxnBatchConfirmationTransaction
;
confirmation_transaction
:
ScrollL2TxnBatchConfirmationTransaction
;
start_block
:
number
;
start_block
:
number
;
end_block
:
number
;
end_block
:
number
;
transaction_count
:
number
;
transaction_count
:
number
|
null
;
data_availability
:
{
data_availability
:
{
batch_data_container
:
'
in_blob4844
'
|
'
in_calldata
'
;
batch_data_container
:
'
in_blob4844
'
|
'
in_calldata
'
;
};
};
...
...
ui/txnBatches/scrollL2/ScrollL2TxnBatchDetails.tsx
View file @
12d7b900
...
@@ -115,6 +115,8 @@ const ScrollL2TxnBatchDetails = ({ query }: Props) => {
...
@@ -115,6 +115,8 @@ const ScrollL2TxnBatchDetails = ({ query }: Props) => {
}
}
</
DetailedInfo
.
ItemValue
>
</
DetailedInfo
.
ItemValue
>
{
typeof
data
.
transaction_count
===
'
number
'
?
(
<>
<
DetailedInfo
.
ItemLabel
<
DetailedInfo
.
ItemLabel
isLoading=
{
isPlaceholderData
}
isLoading=
{
isPlaceholderData
}
hint=
"Number of transactions in this batch"
hint=
"Number of transactions in this batch"
...
@@ -126,6 +128,8 @@ const ScrollL2TxnBatchDetails = ({ query }: Props) => {
...
@@ -126,6 +128,8 @@ const ScrollL2TxnBatchDetails = ({ query }: Props) => {
{
data
.
transaction_count
.
toLocaleString
()
}
transaction
{
data
.
transaction_count
===
1
?
''
:
'
s
'
}
{
data
.
transaction_count
.
toLocaleString
()
}
transaction
{
data
.
transaction_count
===
1
?
''
:
'
s
'
}
</
Link
>
</
Link
>
</
DetailedInfo
.
ItemValue
>
</
DetailedInfo
.
ItemValue
>
</>
)
:
null
}
<
DetailedInfo
.
ItemLabel
<
DetailedInfo
.
ItemLabel
isLoading=
{
isPlaceholderData
}
isLoading=
{
isPlaceholderData
}
...
...
ui/txnBatches/scrollL2/ScrollL2TxnBatchesListItem.tsx
View file @
12d7b900
...
@@ -104,6 +104,8 @@ const ScrollL2TxnBatchesListItem = ({ item, isLoading }: Props) => {
...
@@ -104,6 +104,8 @@ const ScrollL2TxnBatchesListItem = ({ item, isLoading }: Props) => {
</
Link
>
</
Link
>
</
ListItemMobileGrid
.
Value
>
</
ListItemMobileGrid
.
Value
>
{
typeof
item
.
transaction_count
===
'
number
'
?
(
<>
<
ListItemMobileGrid
.
Label
isLoading=
{
isLoading
}
>
Txn count
</
ListItemMobileGrid
.
Label
>
<
ListItemMobileGrid
.
Label
isLoading=
{
isLoading
}
>
Txn count
</
ListItemMobileGrid
.
Label
>
<
ListItemMobileGrid
.
Value
>
<
ListItemMobileGrid
.
Value
>
<
Link
<
Link
...
@@ -115,6 +117,8 @@ const ScrollL2TxnBatchesListItem = ({ item, isLoading }: Props) => {
...
@@ -115,6 +117,8 @@ const ScrollL2TxnBatchesListItem = ({ item, isLoading }: Props) => {
{
item
.
transaction_count
.
toLocaleString
()
}
{
item
.
transaction_count
.
toLocaleString
()
}
</
Link
>
</
Link
>
</
ListItemMobileGrid
.
Value
>
</
ListItemMobileGrid
.
Value
>
</>
)
:
null
}
</
ListItemMobileGrid
.
Container
>
</
ListItemMobileGrid
.
Container
>
);
);
...
...
ui/txnBatches/scrollL2/ScrollL2TxnBatchesTableItem.tsx
View file @
12d7b900
...
@@ -87,12 +87,14 @@ const TxnBatchesTableItem = ({ item, isLoading }: Props) => {
...
@@ -87,12 +87,14 @@ const TxnBatchesTableItem = ({ item, isLoading }: Props) => {
</
Link
>
</
Link
>
</
TableCell
>
</
TableCell
>
<
TableCell
verticalAlign=
"middle"
isNumeric
>
<
TableCell
verticalAlign=
"middle"
isNumeric
>
{
typeof
item
.
transaction_count
===
'
number
'
?
(
<
Link
<
Link
href=
{
route
({
pathname
:
'
/batches/[number]
'
,
query
:
{
number
:
item
.
number
.
toString
(),
tab
:
'
txs
'
}
})
}
href=
{
route
({
pathname
:
'
/batches/[number]
'
,
query
:
{
number
:
item
.
number
.
toString
(),
tab
:
'
txs
'
}
})
}
loading=
{
isLoading
}
loading=
{
isLoading
}
>
>
{
item
.
transaction_count
.
toLocaleString
()
}
{
item
.
transaction_count
.
toLocaleString
()
}
</
Link
>
</
Link
>
)
:
'
N/A
'
}
</
TableCell
>
</
TableCell
>
</
TableRow
>
</
TableRow
>
);
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment