Commit 12d7b900 authored by tom's avatar tom

transactions_count for Scroll batch could be null

parent 5d262cea
...@@ -27,7 +27,7 @@ export type ScrollL2TxnBatch = { ...@@ -27,7 +27,7 @@ export type ScrollL2TxnBatch = {
confirmation_transaction: ScrollL2TxnBatchConfirmationTransaction; confirmation_transaction: ScrollL2TxnBatchConfirmationTransaction;
start_block: number; start_block: number;
end_block: number; end_block: number;
transaction_count: number; transaction_count: number | null;
data_availability: { data_availability: {
batch_data_container: 'in_blob4844' | 'in_calldata'; batch_data_container: 'in_blob4844' | 'in_calldata';
}; };
......
...@@ -115,17 +115,21 @@ const ScrollL2TxnBatchDetails = ({ query }: Props) => { ...@@ -115,17 +115,21 @@ const ScrollL2TxnBatchDetails = ({ query }: Props) => {
} }
</DetailedInfo.ItemValue> </DetailedInfo.ItemValue>
<DetailedInfo.ItemLabel { typeof data.transaction_count === 'number' ? (
isLoading={ isPlaceholderData } <>
hint="Number of transactions in this batch" <DetailedInfo.ItemLabel
> isLoading={ isPlaceholderData }
Transactions hint="Number of transactions in this batch"
</DetailedInfo.ItemLabel> >
<DetailedInfo.ItemValue> Transactions
<Link loading={ isPlaceholderData } href={ route({ pathname: '/batches/[number]', query: { number: data.number.toString(), tab: 'txs' } }) }> </DetailedInfo.ItemLabel>
{ data.transaction_count.toLocaleString() } transaction{ data.transaction_count === 1 ? '' : 's' } <DetailedInfo.ItemValue>
</Link> <Link loading={ isPlaceholderData } href={ route({ pathname: '/batches/[number]', query: { number: data.number.toString(), tab: 'txs' } }) }>
</DetailedInfo.ItemValue> { data.transaction_count.toLocaleString() } transaction{ data.transaction_count === 1 ? '' : 's' }
</Link>
</DetailedInfo.ItemValue>
</>
) : null }
<DetailedInfo.ItemLabel <DetailedInfo.ItemLabel
isLoading={ isPlaceholderData } isLoading={ isPlaceholderData }
......
...@@ -104,17 +104,21 @@ const ScrollL2TxnBatchesListItem = ({ item, isLoading }: Props) => { ...@@ -104,17 +104,21 @@ const ScrollL2TxnBatchesListItem = ({ item, isLoading }: Props) => {
</Link> </Link>
</ListItemMobileGrid.Value> </ListItemMobileGrid.Value>
<ListItemMobileGrid.Label isLoading={ isLoading }>Txn count</ListItemMobileGrid.Label> { typeof item.transaction_count === 'number' ? (
<ListItemMobileGrid.Value> <>
<Link <ListItemMobileGrid.Label isLoading={ isLoading }>Txn count</ListItemMobileGrid.Label>
href={ route({ pathname: '/batches/[number]', query: { number: item.number.toString(), tab: 'txs' } }) } <ListItemMobileGrid.Value>
loading={ isLoading } <Link
fontWeight={ 600 } href={ route({ pathname: '/batches/[number]', query: { number: item.number.toString(), tab: 'txs' } }) }
minW="40px" loading={ isLoading }
> fontWeight={ 600 }
{ item.transaction_count.toLocaleString() } minW="40px"
</Link> >
</ListItemMobileGrid.Value> { item.transaction_count.toLocaleString() }
</Link>
</ListItemMobileGrid.Value>
</>
) : null }
</ListItemMobileGrid.Container> </ListItemMobileGrid.Container>
); );
......
...@@ -87,12 +87,14 @@ const TxnBatchesTableItem = ({ item, isLoading }: Props) => { ...@@ -87,12 +87,14 @@ const TxnBatchesTableItem = ({ item, isLoading }: Props) => {
</Link> </Link>
</TableCell> </TableCell>
<TableCell verticalAlign="middle" isNumeric> <TableCell verticalAlign="middle" isNumeric>
<Link { typeof item.transaction_count === 'number' ? (
href={ route({ pathname: '/batches/[number]', query: { number: item.number.toString(), tab: 'txs' } }) } <Link
loading={ isLoading } href={ route({ pathname: '/batches/[number]', query: { number: item.number.toString(), tab: 'txs' } }) }
> loading={ isLoading }
{ item.transaction_count.toLocaleString() } >
</Link> { item.transaction_count.toLocaleString() }
</Link>
) : 'N/A' }
</TableCell> </TableCell>
</TableRow> </TableRow>
); );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment