Commit 221c1e90 authored by tom's avatar tom

combine eslint and tsc jobs

parent af6ebf25
...@@ -7,11 +7,14 @@ on: ...@@ -7,11 +7,14 @@ on:
- main - main
jobs: jobs:
lint: code_quality:
name: ESLint name: Code quality
runs-on: ubuntu-latest runs-on: ubuntu-latest
if: "!contains(github.event.pull_request.labels.*.name, 'WIP')" if: "!contains(github.event.pull_request.labels.*.name, 'WIP')"
steps: steps:
- name: Cancel previous runs
uses: styfle/cancel-workflow-action@0.11.0
- name: Checkout repo - name: Checkout repo
uses: actions/checkout@v3 uses: actions/checkout@v3
...@@ -29,33 +32,17 @@ jobs: ...@@ -29,33 +32,17 @@ jobs:
- name: Run ESLint - name: Run ESLint
run: yarn lint:eslint run: yarn lint:eslint
type_check:
name: TypeScript
runs-on: ubuntu-latest
if: "!contains(github.event.pull_request.labels.*.name, 'WIP')"
steps:
- name: Checkout repo
uses: actions/checkout@v3
- name: Setup node
uses: actions/setup-node@v3
with:
node-version: 18
cache: 'yarn'
- name: Install dependencies
uses: bahmutov/npm-install@v1
with:
useRollingCache: true
- name: Compile TypeScript - name: Compile TypeScript
run: yarn lint:tsc run: yarn lint:tsc
jest_tests: jest_tests:
name: Run unit tests with Jest name: Run unit tests with Jest
needs: [ lint, type_check ] needs: [ code_quality ]
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- name: Cancel previous runs
uses: styfle/cancel-workflow-action@0.11.0
- name: Checkout repo - name: Checkout repo
uses: actions/checkout@v3 uses: actions/checkout@v3
...@@ -75,12 +62,16 @@ jobs: ...@@ -75,12 +62,16 @@ jobs:
pw_tests: pw_tests:
name: Run components visual tests with PlayWright name: Run components visual tests with PlayWright
needs: [ lint, type_check ] needs: [ code_quality ]
# if: ${{ false }}
runs-on: ubuntu-latest runs-on: ubuntu-latest
container: container:
image: mcr.microsoft.com/playwright:v1.28.0-focal image: mcr.microsoft.com/playwright:v1.32.0-focal
steps: steps:
- name: Cancel Previous Runs
uses: styfle/cancel-workflow-action@0.11.0
- name: Install git-lfs - name: Install git-lfs
run: apt-get update && apt-get install git-lfs run: apt-get update && apt-get install git-lfs
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment