better api error handling

lib/api/handler.ts

@@ -5,8 +5,8 @@ import getUrlWithNetwork from 'lib/api/getUrlWithNetwork';
 
 type Methods = 'GET' | 'POST' | 'PUT' | 'DELETE';
 
-export default function handler<TRes, TErrRes>(getUrl: (_req: NextApiRequest) => string, allowedMethods: Array<Methods>) {
-  return async(_req: NextApiRequest, res: NextApiResponse<TRes | TErrRes>) => {
+export default function handler(getUrl: (_req: NextApiRequest) => string, allowedMethods: Array<Methods>) {
+  return async(_req: NextApiRequest, res: NextApiResponse) => {
     if (_req.method && allowedMethods.includes(_req.method as Methods)) {
       const isBodyDisallowed = _req.method === 'GET' || _req.method === 'HEAD';
 
@@ -17,12 +17,17 @@ export default function handler<TRes, TErrRes>(getUrl: (_req: NextApiRequest) =>
       });
 
       if (response.status !== 200) {
-        const error = await response.json() as { errors: TErrRes };
-        res.status(500).json(error?.errors || {} as TErrRes);
+        try {
+          const error = await response.json() as { errors: unknown };
+          res.status(500).json(error?.errors || {});
+        } catch (error) {
+          res.status(500).json({ statusText: response.statusText, status: response.status });
+        }
+
         return;
       }
 
-      const data = await response.json() as TRes;
+      const data = await response.json();
       res.status(200).json(data);
     } else {
       res.setHeader('Allow', allowedMethods);

pages/api/account/api-keys/index.ts

-import type { ApiKeys, ApiKeyErrors } from 'types/api/account';
-
 import handler from 'lib/api/handler';
 
-const apiKeysHandler = handler<ApiKeys, ApiKeyErrors>(() => '/account/v1/user/api_keys', [ 'GET', 'POST' ]);
+const apiKeysHandler = handler(() => '/account/v1/user/api_keys', [ 'GET', 'POST' ]);
 
 export default apiKeysHandler;

pages/api/account/custom-abis/index.ts

-import type { CustomAbis, CustomAbiErrors } from 'types/api/account';
-
 import handler from 'lib/api/handler';
 
-const customAbiHandler = handler<CustomAbis, CustomAbiErrors>(() => '/account/v1/user/custom_abis', [ 'GET', 'POST' ]);
+const customAbiHandler = handler(() => '/account/v1/user/custom_abis', [ 'GET', 'POST' ]);
 
 export default customAbiHandler;

pages/api/account/private-tags/address/index.ts

-import type { AddressTags, AddressTagErrors } from 'types/api/account';
-
 import handler from 'lib/api/handler';
 
-const addressHandler = handler<AddressTags, AddressTagErrors>(() => '/account/v1/user/tags/address', [ 'GET', 'POST' ]);
+const addressHandler = handler(() => '/account/v1/user/tags/address', [ 'GET', 'POST' ]);
 
 export default addressHandler;

pages/api/account/private-tags/transaction/index.ts

-import type { TransactionTags, TransactionTagErrors } from 'types/api/account';
-
 import handler from 'lib/api/handler';
 
-const transactionHandler = handler<TransactionTags, TransactionTagErrors>(() => '/account/v1/user/tags/transaction', [ 'GET', 'POST' ]);
+const transactionHandler = handler(() => '/account/v1/user/tags/transaction', [ 'GET', 'POST' ]);
 
 export default transactionHandler;

pages/api/account/profile/index.ts

-import type { UserInfo } from 'types/api/account';
-
 import handler from 'lib/api/handler';
 
-const profileHandler = handler<UserInfo, unknown>(() => '/account/v1/user/info', [ 'GET' ]);
+const profileHandler = handler(() => '/account/v1/user/info', [ 'GET' ]);
 
 export default profileHandler;

pages/api/account/public-tags/index.ts

-import type { PublicTags, PublicTagErrors } from 'types/api/account';
-
 import handler from 'lib/api/handler';
 
-const publicKeysHandler = handler<PublicTags, PublicTagErrors>(() => '/account/v1/user/public_tags', [ 'GET', 'POST' ]);
+const publicKeysHandler = handler(() => '/account/v1/user/public_tags', [ 'GET', 'POST' ]);
 
 export default publicKeysHandler;

pages/api/account/watchlist/[id].ts

 import type { NextApiRequest } from 'next';
 
-import type { WatchlistAddresses, WatchlistErrors } from 'types/api/account';
-
 import handler from 'lib/api/handler';
 
 const getUrl = (req: NextApiRequest) => {
   return `/account/v1/user/watchlist/${ req.query.id }`;
 };
 
-const addressEditHandler = handler<WatchlistAddresses, WatchlistErrors>(getUrl, [ 'DELETE', 'PUT' ]);
+const addressEditHandler = handler(getUrl, [ 'DELETE', 'PUT' ]);
 
 export default addressEditHandler;

pages/api/account/watchlist/index.ts

-import type { WatchlistAddresses, WatchlistErrors } from 'types/api/account';
-
 import handler from 'lib/api/handler';
 
-const watchlistHandler = handler<WatchlistAddresses, WatchlistErrors>(() => '/account/v1/user/watchlist', [ 'GET', 'POST' ]);
+const watchlistHandler = handler(() => '/account/v1/user/watchlist', [ 'GET', 'POST' ]);
 
 export default watchlistHandler;