withCopy to noCopy prop

ui/privateTags/TransactionTagTable/TransactionTagListItem.tsx

@@ -30,7 +30,7 @@ const TransactionTagListItem = ({ item, isLoading, onEditClick, onDeleteClick }:
         <TxEntity
           hash={ item.transaction_hash }
           isLoading={ isLoading }
-          withCopy
+          noCopy={ false }
           fontWeight={ 600 }
           maxW="100%"
         />

ui/privateTags/TransactionTagTable/TransactionTagTableItem.tsx

@@ -32,8 +32,8 @@ const TransactionTagTableItem = ({ item, isLoading, onEditClick, onDeleteClick }
         <TxEntity
           hash={ item.transaction_hash }
           isLoading={ isLoading }
+          noCopy={ false }
           fontWeight={ 600 }
-          withCopy
         />
       </Td>
       <Td>

ui/shared/entities/address/AddressEntity.tsx

@@ -101,7 +101,6 @@ const Copy = (props: CopyProps) => {
     <EntityBase.Copy
       { ...props }
       text={ props.address.hash }
-      withCopy={ props.withCopy ?? true }
     />
   );
 };

ui/shared/entities/base/components.tsx

@@ -24,8 +24,7 @@ export interface EntityBaseProps {
   href?: string;
   query?: Record<string, string>;
   noIcon?: boolean;
-  // TODO @tom2drum rename to noCopy
-  withCopy?: boolean;
+  noCopy?: boolean;
   tailLength?: number;
   truncation?: Truncation;
 }
@@ -133,10 +132,10 @@ const Content = chakra(({ className, isLoading, asProp, text, truncation = 'dyna
   );
 });
 
-export type CopyBaseProps = Pick<CopyToClipboardProps, 'isLoading' | 'text'> & Pick<EntityBaseProps, 'withCopy'>;
+export type CopyBaseProps = Pick<CopyToClipboardProps, 'isLoading' | 'text'> & Pick<EntityBaseProps, 'noCopy'>;
 
 const Copy = (props: CopyBaseProps) => {
-  if (!props.withCopy) {
+  if (props.noCopy) {
     return null;
   }
 

ui/shared/entities/token/TokenEntity.tsx

@@ -122,7 +122,6 @@ const Copy = (props: CopyProps) => {
     <EntityBase.Copy
       { ...props }
       text={ props.token.address }
-      withCopy={ props.withCopy ?? true }
     />
   );
 };

ui/shared/entities/tx/TxEntity.pw.tsx

@@ -58,7 +58,7 @@ test('with copy +@dark-mode', async({ mount }) => {
     <TestApp>
       <TxEntity
         hash={ hash }
-        withCopy
+        noCopy={ false }
       />
     </TestApp>,
   );

ui/shared/entities/tx/TxEntity.tsx

@@ -56,6 +56,8 @@ const Copy = (props: CopyProps) => {
     <EntityBase.Copy
       { ...props }
       text={ props.hash }
+      // by default we don't show copy icon, maybe this should be revised
+      noCopy={ props.noCopy ?? true }
     />
   );
 };