Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
F
frontend
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
vicotor
frontend
Commits
f795a619
Unverified
Commit
f795a619
authored
Sep 19, 2023
by
tom goriunov
Committed by
GitHub
Sep 19, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Side menu stays open after selecting a menu item on mobile (#1195)
Fixes #1182
parent
a3ce2759
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
30 additions
and
11 deletions
+30
-11
Burger.tsx
ui/snippets/header/Burger.tsx
+4
-1
NavLink.tsx
ui/snippets/navigation/NavLink.tsx
+3
-1
NavigationMobile.tsx
ui/snippets/navigation/NavigationMobile.tsx
+9
-5
ProfileMenuContent.tsx
ui/snippets/profileMenu/ProfileMenuContent.tsx
+13
-3
ProfileMenuMobile.tsx
ui/snippets/profileMenu/ProfileMenuMobile.tsx
+1
-1
No files found.
ui/snippets/header/Burger.tsx
View file @
f795a619
...
@@ -55,7 +55,10 @@ const Burger = () => {
...
@@ -55,7 +55,10 @@ const Burger = () => {
/>
/>
)
:
<
Box
boxSize=
{
9
}
/>
}
)
:
<
Box
boxSize=
{
9
}
/>
}
</
Flex
>
</
Flex
>
{
networkMenu
.
isOpen
?
<
NetworkMenuContentMobile
tabs=
{
networkMenu
.
availableTabs
}
items=
{
networkMenu
.
data
}
/>
:
<
NavigationMobile
/>
}
{
networkMenu
.
isOpen
?
<
NetworkMenuContentMobile
tabs=
{
networkMenu
.
availableTabs
}
items=
{
networkMenu
.
data
}
/>
:
<
NavigationMobile
onNavLinkClick=
{
onClose
}
/>
}
</
DrawerBody
>
</
DrawerBody
>
</
DrawerContent
>
</
DrawerContent
>
</
Drawer
>
</
Drawer
>
...
...
ui/snippets/navigation/NavLink.tsx
View file @
f795a619
...
@@ -18,9 +18,10 @@ type Props = {
...
@@ -18,9 +18,10 @@ type Props = {
isCollapsed
?:
boolean
;
isCollapsed
?:
boolean
;
px
?:
string
|
number
;
px
?:
string
|
number
;
className
?:
string
;
className
?:
string
;
onClick
?:
()
=>
void
;
}
}
const
NavLink
=
({
item
,
isCollapsed
,
px
,
className
}:
Props
)
=>
{
const
NavLink
=
({
item
,
isCollapsed
,
px
,
className
,
onClick
}:
Props
)
=>
{
const
isMobile
=
useIsMobile
();
const
isMobile
=
useIsMobile
();
const
colors
=
useColors
();
const
colors
=
useColors
();
...
@@ -41,6 +42,7 @@ const NavLink = ({ item, isCollapsed, px, className }: Props) => {
...
@@ -41,6 +42,7 @@ const NavLink = ({ item, isCollapsed, px, className }: Props) => {
px=
{
px
||
{
base
:
3
,
lg
:
isExpanded
?
3
:
'
15px
'
,
xl
:
isCollapsed
?
'
15px
'
:
3
}
}
px=
{
px
||
{
base
:
3
,
lg
:
isExpanded
?
3
:
'
15px
'
,
xl
:
isCollapsed
?
'
15px
'
:
3
}
}
aria
-
label=
{
`${ item.text } link`
}
aria
-
label=
{
`${ item.text } link`
}
whiteSpace=
"nowrap"
whiteSpace=
"nowrap"
onClick=
{
onClick
}
>
>
<
Tooltip
<
Tooltip
label=
{
item
.
text
}
label=
{
item
.
text
}
...
...
ui/snippets/navigation/NavigationMobile.tsx
View file @
f795a619
...
@@ -9,7 +9,11 @@ import NavLink from 'ui/snippets/navigation/NavLink';
...
@@ -9,7 +9,11 @@ import NavLink from 'ui/snippets/navigation/NavLink';
import
NavLinkGroupMobile
from
'
./NavLinkGroupMobile
'
;
import
NavLinkGroupMobile
from
'
./NavLinkGroupMobile
'
;
const
NavigationMobile
=
()
=>
{
interface
Props
{
onNavLinkClick
?:
()
=>
void
;
}
const
NavigationMobile
=
({
onNavLinkClick
}:
Props
)
=>
{
const
{
mainNavItems
,
accountNavItems
}
=
useNavItems
();
const
{
mainNavItems
,
accountNavItems
}
=
useNavItems
();
const
[
openedGroupIndex
,
setOpenedGroupIndex
]
=
React
.
useState
(
-
1
);
const
[
openedGroupIndex
,
setOpenedGroupIndex
]
=
React
.
useState
(
-
1
);
...
@@ -59,7 +63,7 @@ const NavigationMobile = () => {
...
@@ -59,7 +63,7 @@ const NavigationMobile = () => {
if
(
isGroupItem
(
item
))
{
if
(
isGroupItem
(
item
))
{
return
<
NavLinkGroupMobile
key=
{
item
.
text
}
item=
{
item
}
onClick=
{
onGroupItemOpen
(
index
)
}
/>;
return
<
NavLinkGroupMobile
key=
{
item
.
text
}
item=
{
item
}
onClick=
{
onGroupItemOpen
(
index
)
}
/>;
}
else
{
}
else
{
return
<
NavLink
key=
{
item
.
text
}
item=
{
item
}
/>;
return
<
NavLink
key=
{
item
.
text
}
item=
{
item
}
onClick=
{
onNavLinkClick
}
/>;
}
}
})
}
})
}
</
VStack
>
</
VStack
>
...
@@ -73,7 +77,7 @@ const NavigationMobile = () => {
...
@@ -73,7 +77,7 @@ const NavigationMobile = () => {
borderColor=
"divider"
borderColor=
"divider"
>
>
<
VStack
as=
"ul"
spacing=
"1"
alignItems=
"flex-start"
>
<
VStack
as=
"ul"
spacing=
"1"
alignItems=
"flex-start"
>
{
accountNavItems
.
map
((
item
)
=>
<
NavLink
key=
{
item
.
text
}
item=
{
item
}
/>)
}
{
accountNavItems
.
map
((
item
)
=>
<
NavLink
key=
{
item
.
text
}
item=
{
item
}
onClick=
{
onNavLinkClick
}
/>)
}
</
VStack
>
</
VStack
>
</
Box
>
</
Box
>
)
}
)
}
...
@@ -109,10 +113,10 @@ const NavigationMobile = () => {
...
@@ -109,10 +113,10 @@ const NavigationMobile = () => {
borderColor
:
'
divider
'
,
borderColor
:
'
divider
'
,
}
}
}
}
>
>
{
item
.
map
(
subItem
=>
<
NavLink
key=
{
subItem
.
text
}
item=
{
subItem
}
/>)
}
{
item
.
map
(
subItem
=>
<
NavLink
key=
{
subItem
.
text
}
item=
{
subItem
}
onClick=
{
onNavLinkClick
}
/>)
}
</
Box
>
</
Box
>
)
:
)
:
<
NavLink
key=
{
item
.
text
}
item=
{
item
}
mb=
{
1
}
/>,
<
NavLink
key=
{
item
.
text
}
item=
{
item
}
mb=
{
1
}
onClick=
{
onNavLinkClick
}
/>,
)
}
)
}
</
Box
>
</
Box
>
</
Box
>
</
Box
>
...
...
ui/snippets/profileMenu/ProfileMenuContent.tsx
View file @
f795a619
...
@@ -13,9 +13,10 @@ const feature = config.features.account;
...
@@ -13,9 +13,10 @@ const feature = config.features.account;
type
Props
=
{
type
Props
=
{
data
?:
UserInfo
;
data
?:
UserInfo
;
onNavLinkClick
?:
()
=>
void
;
};
};
const
ProfileMenuContent
=
({
data
}:
Props
)
=>
{
const
ProfileMenuContent
=
({
data
,
onNavLinkClick
}:
Props
)
=>
{
const
{
accountNavItems
,
profileItem
}
=
useNavItems
();
const
{
accountNavItems
,
profileItem
}
=
useNavItems
();
const
primaryTextColor
=
useColorModeValue
(
'
blackAlpha.800
'
,
'
whiteAlpha.800
'
);
const
primaryTextColor
=
useColorModeValue
(
'
blackAlpha.800
'
,
'
whiteAlpha.800
'
);
...
@@ -54,10 +55,19 @@ const ProfileMenuContent = ({ data }: Props) => {
...
@@ -54,10 +55,19 @@ const ProfileMenuContent = ({ data }: Props) => {
{
data
.
email
}
{
data
.
email
}
</
Text
>
</
Text
>
)
}
)
}
<
NavLink
item=
{
profileItem
}
isActive=
{
undefined
}
px=
"0px"
isCollapsed=
{
false
}
/>
<
NavLink
item=
{
profileItem
}
isActive=
{
undefined
}
px=
"0px"
isCollapsed=
{
false
}
onClick=
{
onNavLinkClick
}
/>
<
Box
as=
"nav"
mt=
{
2
}
pt=
{
2
}
borderTopColor=
"divider"
borderTopWidth=
"1px"
{
...
getDefaultTransitionProps
()
}
>
<
Box
as=
"nav"
mt=
{
2
}
pt=
{
2
}
borderTopColor=
"divider"
borderTopWidth=
"1px"
{
...
getDefaultTransitionProps
()
}
>
<
VStack
as=
"ul"
spacing=
"0"
alignItems=
"flex-start"
overflow=
"hidden"
>
<
VStack
as=
"ul"
spacing=
"0"
alignItems=
"flex-start"
overflow=
"hidden"
>
{
accountNavItems
.
map
((
item
)
=>
<
NavLink
key=
{
item
.
text
}
item=
{
item
}
isActive=
{
undefined
}
isCollapsed=
{
false
}
px=
"0px"
/>)
}
{
accountNavItems
.
map
((
item
)
=>
(
<
NavLink
key=
{
item
.
text
}
item=
{
item
}
isActive=
{
undefined
}
isCollapsed=
{
false
}
px=
"0px"
onClick=
{
onNavLinkClick
}
/>
))
}
</
VStack
>
</
VStack
>
</
Box
>
</
Box
>
<
Box
mt=
{
2
}
pt=
{
3
}
borderTopColor=
"divider"
borderTopWidth=
"1px"
{
...
getDefaultTransitionProps
()
}
>
<
Box
mt=
{
2
}
pt=
{
3
}
borderTopColor=
"divider"
borderTopWidth=
"1px"
{
...
getDefaultTransitionProps
()
}
>
...
...
ui/snippets/profileMenu/ProfileMenuMobile.tsx
View file @
f795a619
...
@@ -62,7 +62,7 @@ const ProfileMenuMobile = () => {
...
@@ -62,7 +62,7 @@ const ProfileMenuMobile = () => {
<
DrawerOverlay
/>
<
DrawerOverlay
/>
<
DrawerContent
maxWidth=
"260px"
>
<
DrawerContent
maxWidth=
"260px"
>
<
DrawerBody
p=
{
6
}
>
<
DrawerBody
p=
{
6
}
>
<
ProfileMenuContent
data=
{
data
}
/>
<
ProfileMenuContent
data=
{
data
}
onNavLinkClick=
{
onClose
}
/>
</
DrawerBody
>
</
DrawerBody
>
</
DrawerContent
>
</
DrawerContent
>
</
Drawer
>
</
Drawer
>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment