swapprotocol: don't wait for full close in emitcheque (#860)

5c657db7 · Ralph Pichler · GitHub · 5215ac36 · 5c657db7
Commit 5c657db7 authored Oct 23, 2020 by Ralph Pichler Committed by GitHub Oct 23, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 3 deletions

swapprotocol.go pkg/settlement/swap/swapprotocol/swapprotocol.go +2 -3

No files found.
--- a/pkg/settlement/swap/swapprotocol/swapprotocol.go
+++ b/pkg/settlement/swap/swapprotocol/swapprotocol.go
@@ -186,9 +186,8 @@ func (s *Service) EmitCheque(ctx context.Context, peer swarm.Address, cheque *ch
 		if err != nil {
 			_ = stream.Reset()
 		} else {
-			// wait for full close
-			// this ensure the accounting lock for this peer will be held long for the other peer to process the cheque
-			_ = stream.FullClose()
+			// don't wait for full close to avoid deadlocks if cheques are sent simultaneously in both directions
+			go stream.FullClose()
 		}
 	}()