rename tests to not have fail word (#564)

* rename tests

pkg/debugapi/welcome_message_test.go

@@ -49,7 +49,7 @@ func TestSetWelcomeMessage(t *testing.T) {
 			wantStatus: http.StatusOK,
 		},
 		{
-			desc:     "fails - request entity too large",
+			desc:     "error - request entity too large",
 			wantFail: true,
 			message: `zZZbzbzbzbBzBBZbBbZbbbBzzzZBZBbzzBBBbBzBzzZbbBzBBzBBbZz
 			bZZZBBbbZbbZzBbzBbzbZBZzBZZbZzZzZzbbZZBZzzbBZBzZzzBBzZZzzZbZZZzbbbzz
@@ -107,7 +107,7 @@ func TestSetWelcomeMessageInternalServerError(t *testing.T) {
 		WelcomeMesssage: testMessage,
 	})
 	body := bytes.NewReader(data)
-	t.Run("internal server error - failed to store", func(t *testing.T) {
+	t.Run("internal server error - error on store", func(t *testing.T) {
 		wantCode := http.StatusInternalServerError
 		wantResp := jsonhttp.StatusResponse{
 			Message: testError.Error(),

pkg/p2p/libp2p/welcome_message_test.go

@@ -34,7 +34,7 @@ func TestDynamicWelcomeMessage(t *testing.T) {
 				t.Fatalf("expected: %s. got %s", testMessage, got)
 			}
 		})
-		t.Run("fails - message too long", func(t *testing.T) {
+		t.Run("error - message too long", func(t *testing.T) {
 			const testMessage = `Lorem ipsum dolor sit amet, consectetur adipiscing elit.
 			Maecenas eu aliquam enim. Nulla tincidunt arcu nec nulla condimentum nullam sodales` // 141 characters
 

pkg/trojan/message.go

@@ -42,9 +42,10 @@ const (
 	NonceSize      = 32
 	LengthSize     = 2
 	TopicSize      = 32
-	MinerTimeout   = 20 // seconds after which the mining will fail
 )
 
+var minerTimeout = 10 * time.Second
+
 // NewTopic creates a new Topic variable with the given input string
 // the input string is taken as a byte slice and hashed
 func NewTopic(topic string) Topic {
@@ -201,7 +202,7 @@ func (m *Message) toChunk(targets Targets, span []byte) (swarm.Chunk, error) {
 			return swarm.NewChunk(swarm.NewAddress(hash), s), nil
 		}
 		return nil, err
-	case <-time.After(MinerTimeout * time.Second):
+	case <-time.After(minerTimeout):
 		return nil, ErrMinerTimeout
 	}
 }

pkg/trojan/message_test.go

@@ -107,8 +107,8 @@ func TestWrap(t *testing.T) {
 	}
 }
 
-// TestWrapFail tests that the creation of a chunk fails when given targets are invalid
-func TestWrapFail(t *testing.T) {
+// TestWrapError tests that the creation of a chunk fails when given targets are invalid
+func TestWrapError(t *testing.T) {
 	m := newTestMessage(t)
 
 	emptyTargets := trojan.Targets([]trojan.Target{})