Commit 8bd9e28b authored by Ralph Pichler's avatar Ralph Pichler Committed by GitHub

fix remaining logging formatting issues (#865)

parent ac5b402c
...@@ -114,13 +114,13 @@ func (s *server) chunkGetHandler(w http.ResponseWriter, r *http.Request) { ...@@ -114,13 +114,13 @@ func (s *server) chunkGetHandler(w http.ResponseWriter, r *http.Request) {
chunk, err := s.Storer.Get(ctx, storage.ModeGetRequest, address) chunk, err := s.Storer.Get(ctx, storage.ModeGetRequest, address)
if err != nil { if err != nil {
if errors.Is(err, storage.ErrNotFound) { if errors.Is(err, storage.ErrNotFound) {
s.Logger.Trace("chunk: chunk not found. addr %s", address) s.Logger.Tracef("chunk: chunk not found. addr %s", address)
jsonhttp.NotFound(w, "chunk not found") jsonhttp.NotFound(w, "chunk not found")
return return
} }
if errors.Is(err, netstore.ErrRecoveryAttempt) { if errors.Is(err, netstore.ErrRecoveryAttempt) {
s.Logger.Trace("chunk: chunk recovery initiated. addr %s", address) s.Logger.Tracef("chunk: chunk recovery initiated. addr %s", address)
jsonhttp.Accepted(w, "chunk recovery initiated. retry after sometime.") jsonhttp.Accepted(w, "chunk recovery initiated. retry after sometime.")
return return
} }
......
...@@ -198,7 +198,7 @@ func (s *server) doneSplit(w http.ResponseWriter, r *http.Request) { ...@@ -198,7 +198,7 @@ func (s *server) doneSplit(w http.ResponseWriter, r *http.Request) {
_, err = tag.DoneSplit(tagr.Address) _, err = tag.DoneSplit(tagr.Address)
if err != nil { if err != nil {
s.Logger.Debugf("done split: failed for address %v", tagr.Address) s.Logger.Debugf("done split: failed for address %v", tagr.Address)
s.Logger.Error("done split: failed for address %v", tagr.Address) s.Logger.Errorf("done split: failed for address %v", tagr.Address)
jsonhttp.InternalServerError(w, nil) jsonhttp.InternalServerError(w, nil)
return return
} }
......
...@@ -57,7 +57,7 @@ func (s *server) peerBalanceHandler(w http.ResponseWriter, r *http.Request) { ...@@ -57,7 +57,7 @@ func (s *server) peerBalanceHandler(w http.ResponseWriter, r *http.Request) {
peer, err := swarm.ParseHexAddress(addr) peer, err := swarm.ParseHexAddress(addr)
if err != nil { if err != nil {
s.Logger.Debugf("debug api: balances peer: invalid peer address %s: %v", addr, err) s.Logger.Debugf("debug api: balances peer: invalid peer address %s: %v", addr, err)
s.Logger.Error("debug api: balances peer: invalid peer address %s", addr) s.Logger.Errorf("debug api: balances peer: invalid peer address %s", addr)
jsonhttp.NotFound(w, errInvaliAddress) jsonhttp.NotFound(w, errInvaliAddress)
return return
} }
......
...@@ -369,7 +369,7 @@ func (s *Service) AddProtocol(p p2p.ProtocolSpec) (err error) { ...@@ -369,7 +369,7 @@ func (s *Service) AddProtocol(p p2p.ProtocolSpec) (err error) {
_ = s.Disconnect(overlay) _ = s.Disconnect(overlay)
} }
s.logger.Trace("blocklisted a peer %s", peerID) s.logger.Tracef("blocklisted a peer %s", peerID)
_ = s.Disconnect(overlay) _ = s.Disconnect(overlay)
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment