fix(transaction): add a missing return, implement a mock function (#2145)

pkg/transaction/transaction.go

@@ -194,6 +194,7 @@ func (t *transactionService) waitForPendingTx(txHash common.Hash) {
 		if err != nil {
 			if !errors.Is(err, ErrTransactionCancelled) {
 				t.logger.Errorf("error while waiting for pending transaction %x: %v", txHash, err)
+				return
 			}
 			t.logger.Warningf("pending transaction %x cancelled", txHash)
 		} else {

pkg/transaction/transaction_test.go

@@ -119,7 +119,11 @@ func TestTransactionSend(t *testing.T) {
 			signerMockForTransaction(signedTx, sender, chainID, t),
 			store,
 			chainID,
-			monitormock.New(),
+			monitormock.New(
+				monitormock.WithWatchTransactionFunc(func(txHash common.Hash, nonce uint64) (<-chan types.Receipt, <-chan error, error) {
+					return nil, nil, nil
+				}),
+			),
 		)
 		if err != nil {
 			t.Fatal(err)