Close errorful but created streams (#383)

* Close errorful but created streams

Close errorful but created streams (#383)
* Close errorful but created streams
f408b582 · metacertain · GitHub · 6160b927 · f408b582
Commit f408b582 authored Jun 26, 2020 by metacertain Committed by GitHub Jun 26, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

libp2p.go pkg/p2p/libp2p/libp2p.go +4 -0

No files found.
--- a/pkg/p2p/libp2p/libp2p.go
+++ b/pkg/p2p/libp2p/libp2p.go
@@ -462,6 +462,10 @@ func (s *Service) newStreamForPeerID(ctx context.Context, peerID libp2ppeer.ID,
 	swarmStreamName := p2p.NewSwarmStreamName(protocolName, protocolVersion, streamName)
 	st, err := s.host.NewStream(ctx, peerID, protocol.ID(swarmStreamName))
 	if err != nil {
+		if st != nil {
+			s.logger.Debug("stream experienced unexpected early close")
+			_ = st.Close()
+		}
 		if err == multistream.ErrNotSupported || err == multistream.ErrIncorrectVersion {
 			return nil, p2p.NewIncompatibleStreamError(err)
 		}