• Maurelian's avatar
    contracts-bedrock: Fix enforcement of delay on DelayedVetoable (#9050) · 9a59811f
    Maurelian authored
    * contracts-bedrock: Fix enforcement of delay on DelayedVetoable
    
    Prior to this change, a bug existed in the DelayedVetoable contract,
    which resulted in anyone being able to execute a transaction as soon as
    it had been initiated.
    
    A factor in this was an edge case behavior in foundry's vm.expectRevert
    which flips the success value of a low level call. This commit also
    introduces a new convention when expectRevert is used on low level calls
    to make this edge case behavior more evident.
    
    * contracts-bedrock: Add revertsAsExpected to Style Guide
    
    * contracts: Fix compiler warnings
    
    * bindings and semver
    9a59811f
DelayedVetoable.sol 7.74 KB