1. 06 Feb, 2024 5 commits
  2. 05 Feb, 2024 12 commits
    • Tei Im's avatar
      Use engine API that matches hardfork version (#9253) · c0d0db91
      Tei Im authored
      * Use engine API that matches HF
      
      * Simplify engine client code by using EngineAPIVersion
      
      * Return full method string from engine api version methods
      
      * FCUVersion takes payload attributes
      
      * Use a proper method
      
      * Handle switch default case explicitly
      
      * Return fcuV3 if attrs is nil
      
      * Add test cases for engine api version methods
      c0d0db91
    • Inphi's avatar
      ctb: add slither-report.json to gitignore (#9353) · 7bee6ca3
      Inphi authored
      7bee6ca3
    • Matthew Slipper's avatar
      ci: Upgrade CI builder (#9344) · 59366284
      Matthew Slipper authored
      59366284
    • Adrian Sutton's avatar
      op-e2e: Re-enable large preimage e2e test (#9346) · a849efa1
      Adrian Sutton authored
      * Reduce the min size for large preimages in devnet to make it easier to reach the limit.
      * Provide a buffer between target and max batch size to avoid the batcher splitting the large tx across multiple smaller frames.
      a849efa1
    • Adrian Sutton's avatar
    • Matthew Slipper's avatar
      ci: bump Cannon test timeouts (#9343) · 98a0b3c0
      Matthew Slipper authored
      98a0b3c0
    • Will Cory's avatar
      fix: Rename clean (#9327) · d953f1a4
      Will Cory authored
      Co-authored-by: default avatarWill Cory <willcory@Wills-MacBook-Pro.local>
      Co-authored-by: default avatarMatthew Slipper <me@matthewslipper.com>
      d953f1a4
    • Matthew Slipper's avatar
      ci: Slim down CI builder (#9339) · 7bed11c9
      Matthew Slipper authored
      * ci: Slim down CI builder
      
      The CI builder image is downloaded many hundreds of times per day. The larger it is, the longer it takes for each CI executor to spin up which increases overall CI runtime. It also causes a significant amount of bandwidth costs from GCP Artifact Registry. This PR reduces the size of CI builder by moving the Rust toolchain to a dedicated builder image which will only be used with the jobs that require it. The Rust toolchain accounts for more than 50% of the size of the builder image.
      
      * add binutils
      
      * fix path
      
      * Update SVM
      
      * have to source bash first
      
      * bad copy
      
      * add back elf tools
      7bed11c9
    • smartcontracts's avatar
      1ed50c44
    • Matthew Slipper's avatar
      ci: Refactor dependencies to reduce runtime (#9335) · 31845fd2
      Matthew Slipper authored
      * ci: Refactor dependencies to reduce runtime
      
      This PR makes the following changes in order to reduce CI runtime:
      
      1. Move the long-running Cannon E2E tests into a scheduled job. This reduces E2E runtime by 8 minutes.
      2. Updates the `devnet` task to leverage the contract artifacts and cannon pre-state created in order jobs. This job was also updated to use a Geth binary rather than compiling it from source. This reduces devnet runtime by 5 minutes.
      3. Removes intermediate linting, allocs, and geth version check jobs by putting them all in `pnpm-monorepo`. `pnpm-monorepo` already builds the contracts, devnet allocs, and checks the Geth version in parallel so splitting these jobs out actually makes things slower due to CCI image download/environment spin-up overhead. The `pnpm-monorepo` job now plugs into a bunch of downstream jobs.
      4. Refactors the action tests to take advantage of multiple test executors.
      5. Swaps the `bedrock-go-tests` image to a simple CCI base image to reduce runtime (this job alone was taking ~1min due to spin up overhead).
      6. Puts linting in `go-mod-download` to avoid spin-up overhead.
      
      In sum, this PR reduces overall CI runtime from 22 minutes to ~13.
      
      * Use develop as a trigger rather than schedule
      
      * schedule fpp-verify
      31845fd2
    • Axel Kingsley's avatar
      Tool: Receipt Reference Aggregator (#9219) · 5a2ac1b4
      Axel Kingsley authored
      * Data Puller
      
      * comment edits
      
      * remove redundant getTx over RPC
      
      * fix
      
      * Add Write and Merge Functionality
      
      * lint fix
      
      * add gob tooling
      
      * run timer
      
      * batching ; fit and finish ; rebase
      
      * drain results
      
      * fit and finish 2
      
      * error handle
      
      * improved resiliency ; remove ENV
      
      * filename changes
      5a2ac1b4
    • Mark Tyneway's avatar
      stateviz: remove (#9338) · 7b732eaa
      Mark Tyneway authored
      Removes the stateviz code from the repo as it has not
      been used in quite some time. It was removed from the
      docker compose setup. This is part of cleaning up code
      in the monorepo periodically to make sure that we keep
      the codebase clean.
      
      stateviz was useful for visualizing the state of the rollup.
      7b732eaa
  3. 04 Feb, 2024 6 commits
    • Matthew Slipper's avatar
      op-e2e: Reduce flakiness in p2p tests (#9333) · dcdf044f
      Matthew Slipper authored
      P2P tests were flaking sometimes due to the checks asserting that everything received was published. `require.ElementsMatch` requires that lists be equal, sans duplicates. Sometimes, however, messages would get sent multiple times/not be picked up in time for the assertions leading to errors like this following:
      
      ```
      listA:
      ([]string) (len=29) {
       ... elided
       (string) (len=68) "0xd770621d3b0a196087ace7efcb0a8a61b353736526f6095946c714ec134b1648:1",
       (string) (len=69) "0x71a364bf88d4e7e049cfe1635e95c31c9d93435b03a4d20c8863637fc0eb319f:28",
       (string) (len=68) "0xd770621d3b0a196087ace7efcb0a8a61b353736526f6095946c714ec134b1648:1"
      }
      
      listB:
      ([]string) (len=29) {
       (string) (len=68) "0xd770621d3b0a196087ace7efcb0a8a61b353736526f6095946c714ec134b1648:1",
       ... elided
       (string) (len=69) "0xf84acde28fb7b630f9e5d91bddc7c2d4d2e1f4ce29a7d1a4551fee9ac828b10f:29"
      }
      
      extra elements in list A:
      ([]interface {}) (len=1) {
       (string) (len=68) "0xd770621d3b0a196087ace7efcb0a8a61b353736526f6095946c714ec134b1648:1"
      }
      
      extra elements in list B:
      ([]interface {}) (len=1) {
       (string) (len=69) "0xf84acde28fb7b630f9e5d91bddc7c2d4d2e1f4ce29a7d1a4551fee9ac828b10f:29"
      }
      ```
      
      This PR refactors to use `require.Subset` which handles this case while still asserting that everything received was in fact published.
      dcdf044f
    • Danyal Prout's avatar
      e4b6585f
    • protolambda's avatar
      op-chain-ops: ecotone post-activation-checks (#9256) · 93ca50c3
      protolambda authored
      * op-chain-ops: ecotone post-activation-checks
      
      * op-chain-ops: Ecotone post-activation check fixes
      
      * op-chain-ops: check-ecotone fix nonce source
      
      * op-chain-ops: cancun functionality post-validation checks
      
      * fix lint
      
      ---------
      Co-authored-by: default avatarMatthew Slipper <me@matthewslipper.com>
      93ca50c3
    • Inphi's avatar
      ctb: Add leftmost bond payout rule to FDG (#9300) · 22cf0c23
      Inphi authored
      * ctb: Add leftmost bond payout rule to FDG
      
      * Update packages/contracts-bedrock/test/dispute/FaultDisputeGame.t.sol
      Co-authored-by: default avatarclabby <ben@clab.by>
      
      * address @clabby's review
      
      ---------
      Co-authored-by: default avatarclabby <ben@clab.by>
      Co-authored-by: default avatarMatthew Slipper <me@matthewslipper.com>
      22cf0c23
    • Mark Tyneway's avatar
      contracts-bedrock, ci: remove slither (#9319) · 88586b75
      Mark Tyneway authored
      * contracts-bedrock, ci: remove slither
      
      Remove the committed in `slither-report.json` since it is not being used
      as part of code review. Also remove running it as part of CI. We can
      choose to add it back when we have the time for somebody to own making
      it a first class tool, but since we haven't triaged the database yet
      it only adds noise to PRs by adding extra diff and extra overhead by
      forcing a regeneration of the report.
      
      It hasn't found any issues in our code and our other checks are much
      better at finding issues in the code.
      
      Leaving the slither commands in the `package.json` for now but if we
      do not commit to using slither in a way that is very helpful for us
      in 6 months or so, then we should just remove the commands as well.
      
      Maybe we can adopt a way of using slither where it is used before
      doing releases of contracts or before going to audit. Having the diff
      as part of code review is not super helpful for code reviewers.
      It just adds noise in the current form.
      
      * Kick build
      
      ---------
      Co-authored-by: default avatarMatthew Slipper <me@matthewslipper.com>
      88586b75
    • Matthew Slipper's avatar
      indexer: Pad gas estimates (#9329) · 06d06428
      Matthew Slipper authored
      * indexer: Pad gas estimates
      
      Indexer tests flake fairly often due to out of gas errors. Case in point below, from a recent test run. This PR updates the indexer tests to pad gas estimates by 20%. This technique is used elsewhere in the indexer E2E tests, but wasn't being applied consistently.
      
      ```json
      {
        "from": "0x15d34aaf54267db7d7c367839aaf71a00a2c6a65",
        "gas": "0x1f3cc",
        "gasUsed": "0x1edb1",
        "to": "0x978e3286eb805934215a88694d80b09aded68d90",
        "input": "0x",
        "error": "execution reverted",
        "calls": [
          {
            "from": "0x978e3286eb805934215a88694d80b09aded68d90",
            "gas": "0x1889b",
            "gasUsed": "0x1889b",
            "to": "0x8887e7568e81405c4e0d4caaabdda949e3b9d4e4",
            "input": "0x",
            "error": "out of gas",
            "calls": [
              {
                "from": "0x978e3286eb805934215a88694d80b09aded68d90",
                "gas": "0x15560",
                "gasUsed": "0x1f37",
                "to": "0x1c23a6d89f95ef3148bcda8e242cab145bf9c0e4",
                "input": "0xcc731b02",
                "output": "0x0000000000000000000000000000000000000000000000000000000001312d00000000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000000000000000000000000000000000000000008000000000000000000000000000000000000000000000000000000003b9aca0000000000000000000000000000000000000000000000000000000000000f424000000000000000000000000000000000ffffffffffffffffffffffffffffffff",
                "calls": [
                  {
                    "from": "0x1c23a6d89f95ef3148bcda8e242cab145bf9c0e4",
                    "gas": "0x13d07",
                    "gasUsed": "0xba8",
                    "to": "0xffba8944650e26653823658d76a122946f27e2f2",
                    "input": "0xcc731b02",
                    "output": "0x0000000000000000000000000000000000000000000000000000000001312d00000000000000000000000000000000000000000000000000000000000000000a0000000000000000000000000000000000000000000000000000000000000008000000000000000000000000000000000000000000000000000000003b9aca0000000000000000000000000000000000000000000000000000000000000f424000000000000000000000000000000000ffffffffffffffffffffffffffffffff",
                    "value": "0x0",
                    "type": "DELEGATECALL"
                  }
                ],
                "type": "STATICCALL"
              }
            ],
            "value": "0xde0b6b3a7640000",
            "type": "DELEGATECALL"
          }
        ],
        "value": "0xde0b6b3a7640000",
        "type": "CALL"
      }
      ```
      
      * Update indexer/e2e_tests/bridge_transactions_e2e_test.go
      Co-authored-by: default avatarrefcell <abigger87@gmail.com>
      
      ---------
      Co-authored-by: default avatarrefcell <abigger87@gmail.com>
      06d06428
  4. 03 Feb, 2024 1 commit
    • Mark Tyneway's avatar
      op-node: genesis deduplicate json write (#9323) · 0ea5e0b9
      Mark Tyneway authored
      Deduplicate code by using a common json write function from
      `op-service` instead of using one off json write functions.
      This reduces the overall code in the codebase and helps to
      standardize the way that we write json to disk.
      0ea5e0b9
  5. 02 Feb, 2024 16 commits