deps: remove nyc (#11195)

* deps: remove nyc

nyc is an unused dep for code coverage. This commit removes
the dep as it is no longer used. We should remove deps that
are not used as it bloats dependabot fixes in the monorepo
as well as introducing attack vectors. Every dep is a liability
and we should only have deps that we really need.

* ci: cleanup

Remove the calls to code coverage in ci

* ci: add test

.circleci/config.yml

@@ -713,9 +713,6 @@ jobs:
         description: Regex matching dependent packages
         type: string
         default: this-package-does-not-exist
-      coverage_flag:
-        description: Coverage flag name
-        type: string
     docker:
       - image: <<pipeline.parameters.ci_builder_image>>
     resource_class: large
@@ -738,11 +735,8 @@ jobs:
           working_directory: packages/<<parameters.package_name>>
       - run:
           name: Test
-          command: pnpm test:coverage
+          command: pnpm test
           working_directory: packages/<<parameters.package_name>>
-      - run:
-          name: Upload coverage
-          command: codecov --verbose --clean --flags <<parameters.coverage_flag>>
 
   todo-issues:
     machine:
@@ -1551,18 +1545,10 @@ workflows:
             - pnpm-monorepo
       - js-lint-test:
           name: chain-mon-tests
-          coverage_flag: chain-mon-tests
           package_name: chain-mon
           dependencies: "(contracts-bedrock|sdk)"
           requires:
             - pnpm-monorepo
-      - js-lint-test:
-          name: sdk-tests
-          coverage_flag: sdk-tests
-          package_name: sdk
-          dependencies: "contracts-bedrock"
-          requires:
-            - pnpm-monorepo
       - semgrep-scan
       - go-mod-download
       - fuzz-golang:

.gitignore

@@ -2,7 +2,6 @@
 node_modules
 results
 temp
-.nyc_output
 coverage.json
 *.tsbuildinfo
 **/lcov.info

package.json

@@ -17,7 +17,6 @@
     "install:ci": "pnpm install --ignore-scripts --frozen-lockfile && pnpm rebuild nx",
     "install:ci:offline": "pnpm install --ignore-scripts --offline --frozen-lockfile && pnpm rebuild nx",
     "lint": "npx nx run-many --target=lint",
-    "test:coverage": "npx nx run-many --target=test:coverage",
     "lint:ts:check": "npx nx run-many --target=lint:ts:check",
     "lint:check": "npx nx run-many --target=lint:check",
     "lint:fix": "npx nx run-many --target=lint:fix",
@@ -64,7 +63,6 @@
     "mocha": "^10.6.0",
     "nx": "18.2.2",
     "nx-cloud": "latest",
-    "nyc": "^15.1.0",
     "prettier": "^2.8.0",
     "rimraf": "^5.0.5",
     "ts-mocha": "^10.0.0",

packages/chain-mon/package.json

@@ -26,7 +26,6 @@
     "start:faultproof-wd-mon": "tsx ./src/faultproof-wd-mon/service.ts",
     "start:initialized-upgraded-mon": "tsx ./contrib/initialized-upgraded-mon/service.ts",
     "test": "hardhat test",
-    "test:coverage": "nyc hardhat test && nyc merge .nyc_output coverage.json",
     "build": "tsc -p ./tsconfig.json",
     "clean": "rimraf  dist/ ./tsconfig.tsbuildinfo",
     "lint": "pnpm lint:fix && pnpm lint:check",

packages/devnet-tasks/package.json

@@ -16,8 +16,6 @@
     "lint": "pnpm lint:fix && pnpm lint:check",
     "lint:check": "eslint . --max-warnings=0",
     "lint:fix": "pnpm lint:check --fix",
-    "test": "hardhat test",
-    "test:coverage": "nyc hardhat test && nyc merge .nyc_output coverage.json",
     "autogen:docs": "typedoc --out docs src/index.ts"
   },
   "keywords": [
@@ -40,7 +38,6 @@
     "ethers": "^5.7.2",
     "hardhat": "^2.20.1",
     "hardhat-deploy": "^0.12.4",
-    "nyc": "^15.1.0",
     "ts-node": "^10.9.2",
     "typedoc": "^0.25.7",
     "typescript": "^5.5.3"