Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
N
nebula
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
exchain
nebula
Commits
ac02d49e
Commit
ac02d49e
authored
Jul 31, 2023
by
clabby
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
review: Add comment about bubbled up revert in `FaultDisputeGame.initialize`
parent
0e1dc22c
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
0 deletions
+3
-0
FaultDisputeGame.sol
packages/contracts-bedrock/src/dispute/FaultDisputeGame.sol
+3
-0
No files found.
packages/contracts-bedrock/src/dispute/FaultDisputeGame.sol
View file @
ac02d49e
...
@@ -439,6 +439,9 @@ contract FaultDisputeGame is IFaultDisputeGame, Clone, Semver {
...
@@ -439,6 +439,9 @@ contract FaultDisputeGame is IFaultDisputeGame, Clone, Semver {
);
);
// Set the L1 head hash to the block hash of the L1 block number provided.
// Set the L1 head hash to the block hash of the L1 block number provided.
// This call can revert if the block hash oracle does not have information
// about the block number provided to it. This revert will bubble up to the
// DisputeGameFactory and prevent the game from being created.
l1Head = BLOCK_HASH_ORACLE.load(_getArgUint256(0x40));
l1Head = BLOCK_HASH_ORACLE.load(_getArgUint256(0x40));
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment