• Mark Tyneway's avatar
    contracts-bedrock, ci: remove slither (#9319) · 88586b75
    Mark Tyneway authored
    * contracts-bedrock, ci: remove slither
    
    Remove the committed in `slither-report.json` since it is not being used
    as part of code review. Also remove running it as part of CI. We can
    choose to add it back when we have the time for somebody to own making
    it a first class tool, but since we haven't triaged the database yet
    it only adds noise to PRs by adding extra diff and extra overhead by
    forcing a regeneration of the report.
    
    It hasn't found any issues in our code and our other checks are much
    better at finding issues in the code.
    
    Leaving the slither commands in the `package.json` for now but if we
    do not commit to using slither in a way that is very helpful for us
    in 6 months or so, then we should just remove the commands as well.
    
    Maybe we can adopt a way of using slither where it is used before
    doing releases of contracts or before going to audit. Having the diff
    as part of code review is not super helpful for code reviewers.
    It just adds noise in the current form.
    
    * Kick build
    
    ---------
    Co-authored-by: default avatarMatthew Slipper <me@matthewslipper.com>
    88586b75
Name
Last commit
Last update
.changeset Loading commit data...
.circleci Loading commit data...
.github Loading commit data...
.husky Loading commit data...
.vscode Loading commit data...
bedrock-devnet Loading commit data...
cannon Loading commit data...
docs Loading commit data...
endpoint-monitor Loading commit data...
indexer Loading commit data...
op-batcher Loading commit data...
op-bindings Loading commit data...
op-bindings-e2e Loading commit data...
op-bootnode Loading commit data...
op-chain-ops Loading commit data...
op-challenger Loading commit data...
op-conductor Loading commit data...
op-e2e Loading commit data...
op-heartbeat Loading commit data...
op-node Loading commit data...
op-preimage Loading commit data...
op-program Loading commit data...
op-proposer Loading commit data...
op-service Loading commit data...
op-ufm Loading commit data...
op-wheel Loading commit data...
ops Loading commit data...
ops-bedrock Loading commit data...
packages Loading commit data...
proxyd Loading commit data...
specs Loading commit data...
ufm-test-services Loading commit data...
.coderabbit.yml Loading commit data...
.dockerignore Loading commit data...
.editorconfig Loading commit data...
.envrc.example Loading commit data...
.eslintrc.js Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.npmrc Loading commit data...
.nvmrc Loading commit data...
.pnpmfile.cjs Loading commit data...
.prettierrc.js Loading commit data...
.semgrepignore Loading commit data...
.shellcheckrc Loading commit data...
.snyk Loading commit data...
CITATION.cff Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
SECURITY.md Loading commit data...
cloudbuild.yaml Loading commit data...
codecov.yml Loading commit data...
docker-bake.hcl Loading commit data...
go.mod Loading commit data...
go.sum Loading commit data...
nx.json Loading commit data...
package.json Loading commit data...
pnpm-lock.yaml Loading commit data...
pnpm-workspace.yaml Loading commit data...
tsconfig.json Loading commit data...
versions.json Loading commit data...