- 29 Oct, 2023 40 commits
-
-
Maurelian authored
This commit introduces the ability to remove multiple owners at once in the LivenessModule.sol contract. A new function removeOwners has been added, which accepts arrays of previous owners and owners to be removed. The existing removeOwner function has been updated to use a new internal function _removeOwner. The _getPrevOwner function has been removed as it is no longer needed.
-
Maurelian authored
-
Maurelian authored
-
Maurelian authored
-
Maurelian authored
Co-authored-by:
Matt Solomon <matt@mattsolomon.dev>
-
Maurelian authored
Standardizing on the term owner rather than signer except in and around calls to _getNSigners.
-
Maurelian authored
-
Maurelian authored
-
Maurelian authored
There was a bug in the remove all owners flow that would leave two owners on the safe. Fixing that bug required using `swapOwners` in order to remove and replace the last signer, since you cannot remove the only owner and then add a new one (even when calling from a module).
-
Maurelian authored
-
Maurelian authored
-
Maurelian authored
Also added regression tests.
-
Maurelian authored
-
Maurelian authored
Also reorders the functions in the order they are called.
-
Maurelian authored
-
Maurelian authored
-
Maurelian authored
-
Maurelian authored
-
Maurelian authored
-
Maurelian authored
-
Maurelian authored
This required copy/pasting the SignatureDecoder code from the Safe repo.
-
Maurelian authored
-
Maurelian authored
-
Maurelian authored
-
Maurelian authored
-
Maurelian authored
-
Maurelian authored
-
Maurelian authored
-
Maurelian authored
This is more accurate because of the fact that showLiveness can be used without approving a transaction.
-
Maurelian authored
h/t @mds1 Co-authored-by:
Matt Solomon <matt@mattsolomon.dev>
-
Maurelian authored
-
Maurelian authored
OZ's EnumerableSet library is used to store the set of owners prior to execution, and then to compare with the set of owners after execution, and to add/remove those addresses from the mapping accordingly.
-
Maurelian authored
test(ctb): Add test for get75PercentThreshold
-
Maurelian authored
-
Maurelian authored
-
Maurelian authored
-
Maurelian authored
-
Maurelian authored
This change fixes a bug in getNSigners which incorrectly assumed that the length of the signature data could be used to directly determine the number of signatures provided. This is wrong because contract signatures append additional data used for the EIP1271 signature validation.
-
Maurelian authored
working for approvedHashes
-
Maurelian authored
this change is more readable
-