- 24 Sep, 2022 1 commit
-
-
Matthew Slipper authored
* proxyd: Add customizable whitelist error message Alchemy is asking for this so that we can include their affiliate link. * add missing test case * fix error message * goimports
-
- 23 Sep, 2022 7 commits
-
-
smartcontracts authored
* fix(ct): bug in L2OutputOracle constructor Fixes a small bug in the L2OutputOracle constructor where an assertion was being made about the wrong value. Unlikely that this would've caused any significant issues but worth fixing anyway. * Update l1genesis generation code Puts the genesis timestamp inside the simulator, and updates the simulator code to properly wait for blocks to be mined. See the comments in deployer.go and layer_one.go. * Update gas snapshot Co-authored-by:
Matthew Slipper <me@matthewslipper.com> Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Matthew Slipper authored
Version Packages
-
github-actions[bot] authored
-
Matthew Slipper authored
Trigger Releases
-
smartcontracts authored
Moves the L2ToL1MessagePasser to a new address and introduces the LegacyMessagePasser to live at the old address. Co-authored-by:
Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Michael de Hoog authored
Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by:
Matthew Slipper <me@matthewslipper.com>
-
Matthew Slipper authored
Update op-geth to the latest version on the `optimism-history` branch. This version exposes the customizable simulator backend that we need to merge https://github.com/ethereum-optimism/optimism/pull/3322. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
- 22 Sep, 2022 6 commits
-
-
Matthew Slipper authored
* op-node: Fix OPB-04 The length of the ExtraData field was not being checked, which could lead to panics in the MarshalSSZ function. Fixes ENG-2614 * code review fixes * increase resource size Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Maurelian authored
Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Matthew Slipper authored
-
Mark Tyneway authored
* contracts-bedrock: fix `OptimismMintableERC20Created` The names of the event args were backwards from what they were supposed to be. I noticed this while writing integration tests for the sdk. The event is used like this: ```solidity emit OptimismMintableERC20Created(_remoteToken, address(localToken), msg.sender); ``` The event was updated to look like this: ```solidity event OptimismMintableERC20Created( address indexed remoteToken, address indexed localToken, address deployer ); ``` The `remoteToken` is first and the `localToken` is second. * ctb: Avoid extra casting from contract to address * chore: Regen bindings and snapshot * chore: Update bindings Co-authored-by:
Maurelian <maurelian@protonmail.ch> Co-authored-by:
Matthew Slipper <me@matthewslipper.com>
-
smartcontracts authored
Standardizes storage spacer names and makes sure that storage spacers are all using their original variable types. Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
Maurelian authored
-
- 21 Sep, 2022 7 commits
-
-
smartcontracts authored
Improves and simplifies metrics by using better metric labels.
-
Maurelian authored
-
sam-goldman authored
* nft: L-13 Duplicated code * nft: M-08 Upgradeability inconsistencies * fix(ctp): change `CrossDomainEnabled` to `CrossDomainMessenger` * fix(ctp): make `otherBridge` and `messenger` in nft bridge contracts immutable * docs(ctp): update `ERC721Bridge` bridging function docs * re-order `OptimismMintableERC721Factory` event args * remove unnecessary `Initializable` import in nft bridges * changed legacy `CrossDomainEnabled` call to `CrossDomainMessenger Co-authored-by:
Mark Tyneway <mark.tyneway@gmail.com>
-
Maurelian authored
* ctb: Naming and comments to clarify interfaces usage The OptimismMintableERC20 token used two interfaces in its supportsInterface() function. These were confusingly named after the functions that they contain (ie. IL1Token, IRemoteToken), rather than the contracts these interfaces represent. The name has been tweaked slighly, and comments have been added to clarify the intent. fix(ctb): Clearer names for the mintable token iface * ctb: Add bridge() to mintable erc20 interface * chore: bindings
-
Mark Tyneway authored
* op-chain-ops: implement pending withdrawal fetching We need a list of pending withdrawals to be able to migrate the withdrawal hashes to the new withdrawal hash scheme. This commit implements the script for fetching pending withdrawals as well as a unit test for the function responsible for fetching pending withdrawals. From within `op-chain-ops`, the script can be ran as follows: ```golang $ go run cmd/withdrawals/main.go ``` lint * op-chain-ops: go mod tidy Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by:
Matthew Slipper <me@matthewslipper.com>
-
Matthew Slipper authored
-
Michael de Hoog authored
* Fix stateviz JSON deserialization * Spelling nit * Update the variable names too
-
- 20 Sep, 2022 13 commits
-
-
sam-goldman authored
* nft: M-01 Asymmetric failure behavior of ERC721 bridges * nft: N-05 Inconsistent approach to auto-refunding failed token transfers * nft: L-05 Auto withdrawal transactions can be misleading * nft: M-06 Lack of input validation * nft: L-08 ERC721 bridge contracts not using safeTransferFrom * refactor(ctp): fix `FakeOptimismMintableERC721` inherited contract * feat(ctp)!: update nft bridge post-audit * update `CrossDomainEnabled` import paths in nft bridges * bump `OptimismMintableERC721Factory` semver * Update packages/contracts-periphery/contracts/L2/L2ERC721Bridge.sol Co-authored-by:
Maurelian <maurelian@protonmail.ch> * added `localToken` check in the `completeOutBoundTransfer` function in NFT bridges * nit: fix error message in `L1ERC721Bridge` Co-authored-by:
Maurelian <maurelian@protonmail.ch> Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
smartcontracts authored
Optimizes the DTL by making the assumption that CTC and SCC addresses in the AddressManager will NOT change before Bedrock rolls around. This finally makes it possible to properly sync off of a Geth node where events are not indexed. You can still sync from Erigon as an alternative to this commit.
-
Matthew Slipper authored
ci: release step 3
-
Matthew Slipper authored
Version Packages
-
github-actions[bot] authored
-
Matthew Slipper authored
ci: trigger releases
-
Mark Tyneway authored
There were open zeppelin contracts defined in the top level `package.json` as well as in each of the individual packages. We want to be very explicit with the version of the contract dependencies that are used. I believe that the versions local to the packages were being used instead of the globally defined versions, removing them from the top level `package.json` will ensure this. Co-authored-by:
Matthew Slipper <me@matthewslipper.com>
-
Maurelian authored
* fix: Emit DepositFailed in L2 Bridge * chore: Regen bindings * chore: regen bindings Co-authored-by:
Matthew Slipper <me@matthewslipper.com>
-
Matthew Slipper authored
-
Maurelian authored
* fix(ctb): N-03 Assert for impossible condition * fix(ctb): N-04 Confusing else conditions in ProxyAdmin * chore: Regen bindings * chore: regen bindings Co-authored-by:
Matthew Slipper <me@matthewslipper.com>
-
Maurelian authored
* ci: Print forge version * chore(ci): Download and verify codecov uploader * chore(ci): Upload go coverage reports * ci(ctb): Upload forge coverage output * ci(ctb): Add lcov output command * ci: Move codecov uploader install to ci-builder * ci: Pass on codecov failure * ci: Download codecov in ci-builder
-
smartcontracts authored
Fixes a bug in the DTL that would break sync when addresses are changed in the AddressManager. Slightly reduces complexity at the same time by removing an additional request. Co-authored-by:
Matthew Slipper <me@matthewslipper.com> Co-authored-by:
Mark Tyneway <mark.tyneway@gmail.com>
-
Maurelian authored
* fix: M-08 Upgradeability inconsistencies Standardizes the use of storage gaps. Note that we only include a storage gap in contracts which are inherited in our system, not in the childless children * feat: Add custom natspec tag 'upgradeable' * docs(ctb): document natspec tag 'semver' * chore: add changeset
-
- 19 Sep, 2022 3 commits
-
-
Matthew Slipper authored
* proxyd: Fix error message in tests The custom error message wasn't being carried over in batch responses. * review fixes Co-authored-by:
mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
-
smartcontracts authored
* fix(ctp): Drippie Spearbit issue 45 Fixes Spearbit issue 45, saves gas by using calldata parameters instead of memory parameters. * fix(ctp): Drippie Spearbit issue 44 Fixes Spearbit issue 44, documents the count variable and increments count before external calls. * fix(ctp): Drippie Spearbit issue 42 Fixes Spearbit issue 42, saves gas by removing extra SLOADs. * fix(ctp): Drippie Spearbit issue 35 Fixes Spearbit issue 35, corrects contract layout ordering. * fix(ctp): Drippie Spearbit issue 34 Fixes Spearbit issue 34, adds natspec where incomplete. * fix(ctp): Drippie Spearbit issue 32 and 33 Fixes Spearbit issues 32 and 33, clarifies the behavior of the executable function to revert instead of returning false, and removes an unnecessary check as a result. * fix(ctp): Drippie Spearbit issue 31 Fixes Spearbit issue 31, requires explicit opt-in for reentrant drip execution. * fix(ctp): Drippie Spearbit issue 28 Fixes Spearbit issue 28, better documentation of the behavior of execution checks in the drip function. * fix(ctp): Drippie Spearbit issue 21 Fixes Spearbit issue 21, use MIT licensed version of Solmate. * fix(ctp): Drippie Spearbit issue 25 Fixes Spearbit issue 25, reorders DripStatus enum for clarity. * fix(ctp): Drippie Spearbit issue 24 Fixes Spearbit issue 24, use call with value over transfer to avoid future gas issues. * fix(ctp): Drippie Spearbit issue 22 Fixes Spearbit issue 22, removes unnecessary gas parameter. * fix(ctp): Drippie Spearbit issue 39 Fixes Spearbit issue 39, updates Solidity to latest version. Co-authored-by:
Mark Tyneway <mark.tyneway@gmail.com>
-
Maurelian authored
* fix(ctb): L-06 Circumventable requirement that owner and proposer are distinct Overrides the default transferOwnership function to enforce this requirement. Likewise in the initialize function. * chore: Regen bindings * update more file * fix devnet + weth9 * try to fix weth9 again * one more weth9 * update snapshot Co-authored-by:
Matthew Slipper <me@matthewslipper.com>
-
- 18 Sep, 2022 1 commit
-
-
smartcontracts authored
Bumps ethers to 5.7.0 everywhere. Co-authored-by:
Matthew Slipper <me@matthewslipper.com>
-
- 17 Sep, 2022 1 commit
-
-
Maurelian authored
* fix(ctb): M-03 Eth can be send to undeliverable recipient * fix(ctb): M-07 CrossDomainMessenger allows sending messages to unrelayable addresses" * fix(ctb): L-01 Improve deposit docs * fix(ctb): L-09 Misleading inline documentation * fix(ctb): Standard Bridge does not support tokens with transfer fees * fix(ctb): N-07 Unexplained literal values
-
- 16 Sep, 2022 1 commit
-
-
Matthew Slipper authored
* ops: Add oneshot deployment container Adds a one-shot container that runs both op-geth and op-node in the same container. It also embeds the configuration for a specific network in the container in order to cut down on deployment errors. See README.md for full usage and architecture. * remove env var
-