1. 09 Jun, 2023 4 commits
    • Adrian Sutton's avatar
      Merge pull request #5931 from bobanetwork/fix-withdrawals-test · a80c4d67
      Adrian Sutton authored
      op-e2e: Fix bug in TestWithdrawals
      a80c4d67
    • Jason Yellick's avatar
      op-e2e: Fix bug in TestWithdrawals · 769fe00f
      Jason Yellick authored
      The existing TestWithdrawals test attempts to assert that the total fees
      of the prove and finalize transactions are accounted for in the L1
      balance.  But, it re-uses the `calcGasFees` function and passes in the
      `GasTipCap` and the `GasFeeCap` from the L2 transaction, not from the
      actual L1 transactions.  In the event that the gas fee differs on the L2
      from the L1, then the test will fail.
      
      To keep the diff small, this change simply multiplies the GasUsed and
      `EffectiveGasPrice` from the receipts.  This could be moved into a
      helper function like `calcGasFees`.  Using the `EffectiveGasPrice` seems
      just as good or better than relying on the parameters of the original
      transaction, and could be similarly utilized higher in the test for the
      L2 fees.  If we really want to get the parameters from the tx, then
      `ProveAndFinalizeWithdrawal` would need to be modified to return the
      txes.
      769fe00f
    • OptimismBot's avatar
      Merge pull request #5933 from ethereum-optimism/refcell/bootnode/codeowner · 129032f1
      OptimismBot authored
      fix(op-bootnode): Add go-reviewers as codeowner
      129032f1
    • Andreas Bigger's avatar
      Bootnode codeowner · 99d83fb8
      Andreas Bigger authored
      99d83fb8
  2. 08 Jun, 2023 36 commits