This enables full semgrep scans on develop while retaining
incremental scans on PR branches. This should help with the
baseline stats + showing fixed commits.
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* ci: better check for snapshot diff

* contracts-bedrock: unified solmate import

* contracts-bedrock: fix solmate import

* contracts-bedrock: implement Proxy

* contracts-bedrock: implement ProxyAdmin

* bedrock: snapshot

* contracts: make admin work with legacy proxies

* contracts-bedrock: review fixes

* contracts-bedrock: linting

* contracts-bedrock: lint

* contracts-bedrock: review fixes

* contracts-bedrock: snapshot

* contracts-bedrock: rename

* contracts-bedrock: renames

* contracts-bedrock: renaming

* feat: nft bridge from eth network to optimism

* Update yarn.lock

* feat: added event tests

* fixed import path

* feat: added integration tests to nft bridge

* fix: removed constructor logic from l2 bridge so it can exist as a proxy

* fix: updated pr based on maurelian's comments

* deploy scripts
Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>

Bedrock: share more test utils, cleanup derive package structure, move payload/attributes types to eth package (#2761)

* feat(bedrock): move ExecutionPayload, PayloadAttributes and other engine types from l2 to eth package

* chore(bedrock): clean up derive package, move test util out or polish for public use, split payload_attributes and improve file names

* chore(bedrock): move more test utils out of derive and driver packages into shared package

* bedrock: fix go import newlines/order

* testutils: describe TestID usage
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Have BSV2 collect default node metrics
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Version Packages

Develop -> Master

Fix for BSV2 to expose default options in the metadata metric.
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

feat(cmn): BSV2 server logs to logger

Sends BSV2 server logs to this.logger instead of stdout.

* CI: Update semgrep rules & config

* e2e tests: Fix leaky timer (#2745)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

When `err` is nil, `IsRetryableError` panics.

Develop -> Master

Version Packages

Develop -> Master

Updates BaseServiceV2 to require a version string. Also now exports
parameters in a synthetic metric but ignores any parameters explicitly
marked secret.

Updates BaseServiceV2 to expose a full server instead of simply exposing
the server for metrics. Services can now add new custom routes to this
server. Mainly useful because we're already running the metrics server,
so we might as well allow people to add more things to it.

* Deposit Fee Spec

* Update guaranteed-gas-market.md

* Update guaranteed-gas-market.md

* Update guaranteed-gas-market.md

* PR Fixes

* PR Changes
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Add semgrep to CI

* Add ignore file

* Flag only new semgrep findings

* Update config.yml
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

- Sets Teleportr's status to unavailable if there is a lag between deposits and disbursements.
- Automatically retries disbursements that failed due to networking errors.

Bumps [github.com/ethereum/go-ethereum](https://github.com/ethereum/go-ethereum) from 1.10.16 to 1.10.17.
- [Release notes](https://github.com/ethereum/go-ethereum/releases)
- [Commits](https://github.com/ethereum/go-ethereum/compare/v1.10.16...v1.10.17)

---
updated-dependencies:
- dependency-name: github.com/ethereum/go-ethereum
  dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Matthew Slipper <me@matthewslipper.com>

contracts: fix broken contracts tests

Fixes a simple off-by-one error in the highestCheckedBatchIndex metric.
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Updates the fault-detector to use a smarter starting height by default.
Specifically, the fault-detector will now start at the first batch that
has not yet crossed the challenge period, since the general trust
assumption is that invalid batches will not pass the challenge period.
Significantly reduces verification time, especially since the fault
detector is stateless and does not keep track of the highest verified
batch.
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

The `contracts` tests included a test that did a deep equality check
against two bignumbers. This check stopped working due to changes
in the bignumber implementations used, two bignumbers of the same number
no longer were considered equal. This commit fixes that problem by
using the same version of ethers as `hardhat` and also stringifying
the results so that strings are compared instead of objects. This
fixes the broken tests.

l2geth: skip flaky tests

Develop -> Master

Version Packages

Develop -> Master

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Re-deploys the RetroReceiver with a new default owner called the
Dedicated Deterministic Deployer address. When deploying authenticated
smart contracts deterministically to the same address on many chains,
it's necessary to have a known static owner that then transfers
ownership to the final owner after deployment (which can be different on
every chain). This PR re-deploys the original contract with that new
default owner, the DDD.
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

This was previously missing.
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* specs: Update executePayloadV1 to newPayloadV1

Just updating the name in the specs. This has already been changed
in the code.

* specs: Deposits -> Withdrawals spec clarification

Wording was incorrect.

* specs: Remove unnecessary cast

The casts from bytes32 -> uint256 -> bytes32 is not needed.

* specs: no alias on withdrawals

* fix lint

* specs: fix parentheses
Co-authored-by: Diederik Loerakker <proto@protolambda.com>
Co-authored-by: Maurelian <maurelian@protonmail.ch>
Co-authored-by: Diederik Loerakker <proto@protolambda.com>

BaseServiceV2 will expose internal options (loop interval, metrics port,
etc) as environment variables or command line options.

Fixes a panic in the websocket proxyd logic. Normally, the `clientPump` and `backendPump` methods in `WSProxier` send data in one direction. However, when the client sends an invalid RPC, the `clientPump` will send a response _directly to the client_ in order to avoid unnecessary roundtrips to the backend. This could be interleaved with concurrent writes to the client's WS in `backendPump`, and would cause a panic in the WS library.

To test this, this PR includes a dedicated integration test that reliably triggers the issue. In addition, this PR adds additional testing for WS functionality.