- 09 Oct, 2024 10 commits
-
-
Matt Solomon authored
-
Adrian Sutton authored
-
Adrian Sutton authored
Restores compatibility with the target name people are used to using for e2e tests and that is mentioned in the README and error messages etc.
-
smartcontracts authored
Updates the dockerfile for building contracts-bedrock to use just forge-build instead of just build since just build now does a few other things for the sake of devex.
-
Chen Kai authored
Signed-off-by:
Chen Kai <281165273grape@gmail.com>
-
Chen Kai authored
Signed-off-by:
Chen Kai <281165273grape@gmail.com>
-
Blaine Malone authored
* OPCM: AddressManager and ProxyAdmin assertions. * fix: Added logic for proxy types to check implementations. * fix: touch ups for RDP impl checking. * fix: fully fledged proxies added to tests because of new assertions. * fix: removing console2 lib. * fix: semgrep complaining. * fix: comment cleanup and logical split to avoid stack too deep error. * fix: adding comment back in. * fix: added natspec comments for new DeployUtils functions. * fix: removed unused imports.
-
smartcontracts authored
Ports the interface checks command to go. Updates build command to execute forge fmt and the interface checks.
-
John Chase authored
* 1. Added `WithRegisters` for initializing state's `Registers`. 2. Added `ThreadProofEncoder` helper function to generate `ThreadProof`. 3. Updated `AssertEVMReverts` to include `statePCs` for multiple memory requirements, added `ProofData` parameter for passing `ThreadProof`, and introduced `expectedReason` parameter for more precise testing. 4. Revised `TestEVMFault` and `TestEVM_UnsupportedSyscall` test functions to be compatible with `AssertEVMReverts`. * lint fix and comment fix * avoid false negatives * delete WithRegisters && create ProofGenerator * assert multi outputs * fix naming issue * Update cannon/mipsevm/tests/evm_multithreaded_test.go Nice catch! Co-authored-by:
mbaxter <meredith.a.baxter@gmail.com> * Small fix * link check * make expectedReason a value & delete nil check --------- Co-authored-by:
mbaxter <meredith.a.baxter@gmail.com>
-
Maurelian authored
-
- 08 Oct, 2024 13 commits
-
-
Adrian Sutton authored
Update README to use singlethreaded-2 since the old singlethreaded likely isn't available if just compiling the latest version.
-
Axel Kingsley authored
* op-node,op-supervisor: feed local-unsafe/local-safe/l1-finalized data to supervisor * op-node,op-service,op-e2e: wip, fix interop op-node tests * post-rebase compilation fixes * BlockRef * op-supervisor: fix service test, cleanup todo * op-supervisor: link TODO comments to issue * interop: fix e2e action test --------- Co-authored-by:
protolambda <proto@protolambda.com>
-
George Knee authored
-
Adrian Sutton authored
op-program: Avoid parsing op-sepolia and op-mainnet rollup and chain configs in init() methods (#12307) This was causing op-program to spend cycles parsing the config JSON files to set constants that weren't actually used.
-
smartcontracts authored
Adds semgrep-scan-local to top-level justfile.
-
smartcontracts authored
Adds a new configuration to DeployImplementations so that it knows which MIPS version to deploy.
-
Mark Tyneway authored
It began to error after https://github.com/ethereum-optimism/optimism/pull/12336
-
Blaine Malone authored
* OPCM: DepolyOPChain additional testing checks. * fix: absolute prestate. * fix: adding to assertions. * fix: maxClockDuration check added.
-
smartcontracts authored
Adds MIPSInstructions as an exception to malformed require.
-
smartcontracts authored
Adds the Solidity unused imports check to ci.
-
Paul Dowman authored
-
smartcontracts authored
A few things in this commit: - Adds a new check for unused imports in contracts - Cleans up contracts based on that check - Removes several files that aren't being used anymore
-
smartcontracts authored
Adds sol-style-malformed-revert to local semgrep and fixes the rule so that it actually works. Fixes a couple of findings that the updated rule discovered.
-
- 07 Oct, 2024 5 commits
-
-
Mark Tyneway authored
* contracts-bedrock: fixes `OptimismMintableERC721Factory` test This contract is only used as a predeploy so it should be tested based on the L2 genesis generation setup. Ensures that the address is stored and labeled as part of in memory test setup, as well as updates the tests to work based on the predeploy. This is a small refactor to make future Standard L2 genesis work more simple. Also includes a small ABI fix to the `OptimismMintableERC721Factory` since this contract has not been updated to decouple immutable naming conventions from its ABI. * snapshots: update * checks: fix * lint: fix * typo: fix
-
Mark Tyneway authored
* contracts-bedrock: cleanup `FeeVault` Updates the `FeeVault` to follow modern conventions used in the repo by moving to usage of interfaces rather than implementations. Also moves the `FeeVault` into the `L2` package as its only really useful on L2. This is meant to reduce the diff for the Stanard L2 Genesis by breaking up the refactor into its own small PR. * contracts: update semver-lock * semver-lock: fixup * cleanup: refactor * lint: fix * snapshots: regenerate * interface check: ignore fee vaults There is an issue with normalization of enums when they are return values
-
smartcontracts authored
Adds sol-style-malformed-require to local semgrep and actually fixes the rule so that it works. Fixes a couple of findings that the rule found.
-
George Knee authored
-
Michael de Hoog authored
-
- 06 Oct, 2024 4 commits
-
-
smartcontracts authored
Updates contracts-bedrock-tests to use foundry profiles to set the fuzz/invariant run parameters instead of inlining it. Has the added benefit of separating out into two profiles so that tests can be selectively tuned down for the heavy fuzz pipeline without also tuning them down for the standard CI pipeline.
-
smartcontracts authored
Cleans up the existing semgrep rules and gets rid of the blanket ignores that were being applied everywhere now that we can add ignores for specific files in the rule config.
-
Mark Tyneway authored
* contracts: clean up deploy script abstractions Move the implementation deployments into `deployImplementations` and the initializations into the initizer function so that things are grouped more logically. Even though we use OPSM for modern deployments, the legacy code is still in the repo. This change makes it easier to implement Standard L2 Genesis, where we depend on the `OptimismPortal` being initialized before the `SystemConfig`, since the `SystemConfig` makes calls to the portal during its `initialize` call. * op-e2e: remove dependency on contracts existing Modularizes the functionality more * lint: fix
-
smartcontracts authored
Adds the sol-expectrevert-no-args semgrep rule locally.
-
- 05 Oct, 2024 8 commits
-
-
dependabot[bot] authored
* dependabot(gomod): bump golang.org/x/crypto from 0.27.0 to 0.28.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.27.0 to 0.28.0. - [Commits](https://github.com/golang/crypto/compare/v0.27.0...v0.28.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by:
dependabot[bot] <support@github.com> * deps: fix go.mod --------- Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by:
Mark Tyneway <mark.tyneway@gmail.com>
-
Maurelian authored
* feat(ci): allow solc warnings on tests * Test: forge build with warnings in test * Revert "Test: forge build with warnings in test" This reverts commit b47982948a1ba8b2dbdb8806854326d903b52b49.
-
smartcontracts authored
Adds the sol-style-doc-comment semgrep rule locally. Fixes one instance that was caught by the rule.
-
Raffaele authored
Fix SECURITY.md
-
Mark Tyneway authored
* contracts: update chain assertions Updates the assertion that the storage is either 1 or 0xff. This enables the usage of `_disableInitializers` which is required for the Standard L2 Genesis project, so that the `SystemConfig` doesn't make external calls during its deployment. * lint: fix * nit: address naming * rebase and fix build * build: fix * build: fix
-
Maurelian authored
* feat: Move DEFAULT_STARTING_ANCHOR_ROOTS to Constants library * feat: Move DEFAULT_STARTING_ANCHOR_ROOTS to scripts/libraries/Constants * fix: import error
-
dependabot[bot] authored
Bumps [golang.org/x/time](https://github.com/golang/time) from 0.6.0 to 0.7.0. - [Commits](https://github.com/golang/time/compare/v0.6.0...v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/time dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by:
dependabot[bot] <support@github.com> Co-authored-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
Maurelian authored
* feat: Move deployImplementations up to align with order of usage * feat: Add OPCM to deployImplementations * fix: compiler warning
-