Skip to content

N
nebula
Switch branch/tag
  1. 21 Sep, 2022 5 commits
    • sam-goldman's avatar
      nft: L-13 and M-08 (#3491) · ec8a5110
      sam-goldman authored 
      * nft: L-13 Duplicated code

* nft: M-08 Upgradeability inconsistencies

* fix(ctp): change `CrossDomainEnabled` to `CrossDomainMessenger`

* fix(ctp): make `otherBridge` and `messenger` in nft bridge contracts immutable

* docs(ctp): update `ERC721Bridge` bridging function docs

* re-order `OptimismMintableERC721Factory` event args

* remove unnecessary `Initializable` import in nft bridges

* changed legacy `CrossDomainEnabled` call to `CrossDomainMessenger
Co-authored-by: default avatarMark Tyneway <mark.tyneway@gmail.com>
      ec8a5110
    • Maurelian's avatar
      ctb: Naming and comments to clarify interfaces usage (#3439) · cb5fed67
      Maurelian authored 
      * ctb: Naming and comments to clarify interfaces usage

The OptimismMintableERC20 token used two interfaces in its
supportsInterface() function. These were confusingly named
after the functions that they contain (ie. IL1Token, IRemoteToken),
rather than the contracts these interfaces represent.
The name has been tweaked slighly, and comments have been added to
clarify the intent.

fix(ctb): Clearer names for the mintable token iface

* ctb: Add bridge() to mintable erc20 interface

* chore: bindings
      cb5fed67
    • Mark Tyneway's avatar
      op-chain-ops: add cross domain utils (#3402) · 620d12cf
      Mark Tyneway authored 
      * op-chain-ops: implement pending withdrawal fetching

We need a list of pending withdrawals to be able to
migrate the withdrawal hashes to the new withdrawal
hash scheme. This commit implements the script for
fetching pending withdrawals as well as a unit test
for the function responsible for fetching pending withdrawals.

From within `op-chain-ops`, the script can be ran as follows:

```golang
$ go run cmd/withdrawals/main.go
```

lint

* op-chain-ops: go mod tidy
Co-authored-by: default avatarmergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: default avatarMatthew Slipper <me@matthewslipper.com>
      620d12cf
    • Matthew Slipper's avatar
      ci-builder: Remove ugly shell hack (#3513) · fcfcf6e7
      Matthew Slipper authored
      fcfcf6e7
    • Michael de Hoog's avatar
      Fix Bedrock devnet stateviz container (#3511) · 6cb2110b
      Michael de Hoog authored 
      * Fix stateviz JSON deserialization

* Spelling nit

* Update the variable names too
      6cb2110b
  3. 20 Sep, 2022 12 commits
  5. 19 Sep, 2022 3 commits
    • Matthew Slipper's avatar
      proxyd: Fix error message in tests (#3503) · 1bf9559c
      Matthew Slipper authored 
      * proxyd: Fix error message in tests

The custom error message wasn't being carried over in batch responses.

* review fixes
Co-authored-by: default avatarmergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
      1bf9559c
    • smartcontracts's avatar
      fix(ctp): Drippie Spearbit audit fixes (#3280) · 0ceff8b8
      smartcontracts authored 
      * fix(ctp): Drippie Spearbit issue 45

Fixes Spearbit issue 45, saves gas by using calldata parameters instead
of memory parameters.

* fix(ctp): Drippie Spearbit issue 44

Fixes Spearbit issue 44, documents the count variable and increments
count before external calls.

* fix(ctp): Drippie Spearbit issue 42

Fixes Spearbit issue 42, saves gas by removing extra SLOADs.

* fix(ctp): Drippie Spearbit issue 35

Fixes Spearbit issue 35, corrects contract layout ordering.

* fix(ctp): Drippie Spearbit issue 34

Fixes Spearbit issue 34, adds natspec where incomplete.

* fix(ctp): Drippie Spearbit issue 32 and 33

Fixes Spearbit issues 32 and 33, clarifies the behavior of the
executable function to revert instead of returning false, and removes an
unnecessary check as a result.

* fix(ctp): Drippie Spearbit issue 31

Fixes Spearbit issue 31, requires explicit opt-in for reentrant drip
execution.

* fix(ctp): Drippie Spearbit issue 28

Fixes Spearbit issue 28, better documentation of the behavior of
execution checks in the drip function.

* fix(ctp): Drippie Spearbit issue 21

Fixes Spearbit issue 21, use MIT licensed version of Solmate.

* fix(ctp): Drippie Spearbit issue 25

Fixes Spearbit issue 25, reorders DripStatus enum for clarity.

* fix(ctp): Drippie Spearbit issue 24

Fixes Spearbit issue 24, use call with value over transfer to avoid
future gas issues.

* fix(ctp): Drippie Spearbit issue 22

Fixes Spearbit issue 22, removes unnecessary gas parameter.

* fix(ctp): Drippie Spearbit issue 39

Fixes Spearbit issue 39, updates Solidity to latest version.
Co-authored-by: default avatarMark Tyneway <mark.tyneway@gmail.com>
      0ceff8b8
    • Maurelian's avatar
      Ensure the Oracle's owner and proposer accounts are unique (#3451) · af3e56b1
      Maurelian authored 
      * fix(ctb): L-06 Circumventable requirement that owner and proposer are distinct

Overrides the default transferOwnership function to enforce this
requirement. Likewise in the initialize function.

* chore: Regen bindings

* update more file

* fix devnet + weth9

* try to fix weth9 again

* one more weth9

* update snapshot
Co-authored-by: default avatarMatthew Slipper <me@matthewslipper.com>
      af3e56b1
  7. 18 Sep, 2022 1 commit
  9. 17 Sep, 2022 1 commit
    • Maurelian's avatar
      Various improvements to documentation in the smart contracts and deposit spec (#3440) · a61265ff
      Maurelian authored 
      * fix(ctb): M-03 Eth can be send to undeliverable recipient

* fix(ctb): M-07  CrossDomainMessenger allows sending messages to unrelayable addresses"

* fix(ctb): L-01 Improve deposit docs

* fix(ctb): L-09 Misleading inline documentation

* fix(ctb):  Standard Bridge does not support tokens with transfer fees

* fix(ctb): N-07 Unexplained literal values
      a61265ff
  11. 16 Sep, 2022 18 commits