• Mark Tyneway's avatar
    contracts-bedrock, ci: remove slither (#9319) · 88586b75
    Mark Tyneway authored
    * contracts-bedrock, ci: remove slither
    
    Remove the committed in `slither-report.json` since it is not being used
    as part of code review. Also remove running it as part of CI. We can
    choose to add it back when we have the time for somebody to own making
    it a first class tool, but since we haven't triaged the database yet
    it only adds noise to PRs by adding extra diff and extra overhead by
    forcing a regeneration of the report.
    
    It hasn't found any issues in our code and our other checks are much
    better at finding issues in the code.
    
    Leaving the slither commands in the `package.json` for now but if we
    do not commit to using slither in a way that is very helpful for us
    in 6 months or so, then we should just remove the commands as well.
    
    Maybe we can adopt a way of using slither where it is used before
    doing releases of contracts or before going to audit. Having the diff
    as part of code review is not super helpful for code reviewers.
    It just adds noise in the current form.
    
    * Kick build
    
    ---------
    Co-authored-by: default avatarMatthew Slipper <me@matthewslipper.com>
    88586b75
Name
Last commit
Last update
..
chain-mon Loading commit data...
common-ts Loading commit data...
contracts-bedrock Loading commit data...
contracts-ts Loading commit data...
core-utils Loading commit data...
fee-estimation Loading commit data...
sdk Loading commit data...
web3js-plugin Loading commit data...