1. 04 Dec, 2023 5 commits
    • Matthew Slipper's avatar
      ctb: Fix multithreaded test race · f1ec8e63
      Matthew Slipper authored
      `generate-l2-genesis.sh` is causing spurious test failures. The `.testdata/genesis.json` file comes up as zero-length in tests, even when the script checks for its length before exiting. I believe this is because multiple processes are executing the `generate-l2-genesis.sh` file at once, which causes a race condition where different invocations of the script cause the genesis file to be truncated.
      
      This PR attempts to fix the issue by using a temporary directory as a lock to prevent multiple invocations of the `generate-l2-genesis.sh` script from running at the same time. Directory creations are atomic in Bash, so we can use this technique to create a mutex. If the directory can't be created, then the script will assume that another script is writing the genesis file and wait up to 5 minutes for it to be created. The script uses `trap` to delete the mutex directory when it's done.
      f1ec8e63
    • Matthew Slipper's avatar
      Merge pull request #8411 from ethereum-optimism/feat/kill-geth · 9216562e
      Matthew Slipper authored
      op-e2e: Actually kill geth on shim termination
      9216562e
    • Matthew Slipper's avatar
      op-e2e: Actually kill geth on shim termination · d8dc029e
      Matthew Slipper authored
      The shim creates a new op-geth process, which was not being killed when the shim itself was killed. This prevented termination signals from the test process from propagating to op-geth, which left orphan processes hanging around. Turns out that not a single op-geth process was being explicitly terminated.
      d8dc029e
    • Adrian Sutton's avatar
      Merge pull request #8408 from sukey2008/develop · 6d701ce4
      Adrian Sutton authored
      Fix one typo
      6d701ce4
    • Sukey's avatar
      Fix one typo · 6a048836
      Sukey authored
      6a048836
  2. 02 Dec, 2023 30 commits
  3. 01 Dec, 2023 5 commits